From: Dmitry Vyukov <dvyukov@google.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] x86: remove unused atomic_inc_short()
Date: Wed, 22 Mar 2017 18:46:30 +0100 [thread overview]
Message-ID: <CACT4Y+azHhr-_vTHuws76Q0m9YGkW+Q3+vEhftQc+Q=9t0qUtw@mail.gmail.com> (raw)
In-Reply-To: <0ea4124d-28f8-bf54-03f0-ceee60f3cf8d@virtuozzo.com>
On Wed, Mar 22, 2017 at 5:13 PM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
>
>
> On 03/22/2017 05:10 PM, Dmitry Vyukov wrote:
>> It is completely unused and implemented only on x86.
>> Remove it.
>>
>> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
>> Suggested-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
>
> Not me, it was Mark Rutland <mark.rutland@arm.com>
Mailed v2 with proper attribution.
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: "H. Peter Anvin" <hpa@zytor.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: x86@kernel.org
>>
>> ---
>>
>> Andrew, I think it needs to go into mm as
>> the atomic-instrumented.h patch is in mm.
>> ---
>> arch/tile/lib/atomic_asm_32.S | 3 +--
>> arch/x86/include/asm/atomic.h | 13 -------------
>> include/asm-generic/atomic-instrumented.h | 6 ------
>> 3 files changed, 1 insertion(+), 21 deletions(-)
>>
>> diff --git a/arch/tile/lib/atomic_asm_32.S b/arch/tile/lib/atomic_asm_32.S
>> index 1a70e6c0f259..94709ab41ed8 100644
>> --- a/arch/tile/lib/atomic_asm_32.S
>> +++ b/arch/tile/lib/atomic_asm_32.S
>> @@ -24,8 +24,7 @@
>> * has an opportunity to return -EFAULT to the user if needed.
>> * The 64-bit routines just return a "long long" with the value,
>> * since they are only used from kernel space and don't expect to fault.
>> - * Support for 16-bit ops is included in the framework but we don't provide
>> - * any (x86_64 has an atomic_inc_short(), so we might want to some day).
>> + * Support for 16-bit ops is included in the framework but we don't provide any.
>> *
>> * Note that the caller is advised to issue a suitable L1 or L2
>> * prefetch on the address being manipulated to avoid extra stalls.
>> diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h
>> index 0cde164f058a..9ff8738103eb 100644
>> --- a/arch/x86/include/asm/atomic.h
>> +++ b/arch/x86/include/asm/atomic.h
>> @@ -237,19 +237,6 @@ ATOMIC_OPS(xor, ^)
>>
>> int __arch_atomic_add_unless(atomic_t *v, int a, int u);
>>
>> -/**
>> - * arch_atomic_inc_short - increment of a short integer
>> - * @v: pointer to type int
>> - *
>> - * Atomically adds 1 to @v
>> - * Returns the new value of @u
>> - */
>> -static __always_inline short int arch_atomic_inc_short(short int *v)
>> -{
>> - asm(LOCK_PREFIX "addw $1, %0" : "+m" (*v));
>> - return *v;
>> -}
>> -
>> #ifdef CONFIG_X86_32
>> # include <asm/atomic64_32.h>
>> #else
>> diff --git a/include/asm-generic/atomic-instrumented.h b/include/asm-generic/atomic-instrumented.h
>> index 951bcd083925..70742da13087 100644
>> --- a/include/asm-generic/atomic-instrumented.h
>> +++ b/include/asm-generic/atomic-instrumented.h
>> @@ -78,12 +78,6 @@ static __always_inline bool atomic64_add_unless(atomic64_t *v, long long a,
>> return arch_atomic64_add_unless(v, a, u);
>> }
>>
>> -static __always_inline short int atomic_inc_short(short int *v)
>> -{
>> - kasan_check_write(v, sizeof(*v));
>> - return arch_atomic_inc_short(v);
>> -}
>> -
>> #define __INSTR_VOID1(op, sz) \
>> static __always_inline void atomic##sz##_##op(atomic##sz##_t *v) \
>> { \
>>
prev parent reply other threads:[~2017-03-22 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 14:10 [PATCH] x86: remove unused atomic_inc_short() Dmitry Vyukov
2017-03-22 16:13 ` Andrey Ryabinin
2017-03-22 17:46 ` Dmitry Vyukov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACT4Y+azHhr-_vTHuws76Q0m9YGkW+Q3+vEhftQc+Q=9t0qUtw@mail.gmail.com' \
--to=dvyukov@google.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).