From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADD4CA9EB9 for ; Mon, 21 Oct 2019 15:15:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 507782084B for ; Mon, 21 Oct 2019 15:15:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="g2j1B98P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729563AbfJUPPb (ORCPT ); Mon, 21 Oct 2019 11:15:31 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:36566 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728018AbfJUPPa (ORCPT ); Mon, 21 Oct 2019 11:15:30 -0400 Received: by mail-qt1-f196.google.com with SMTP id d17so6945567qto.3 for ; Mon, 21 Oct 2019 08:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ACBxtsWVb2OWpcnIOOtAMcXYGAqFOpXwv6cGgopBFYM=; b=g2j1B98PKHwC/5/5uHlj+nPQC2YEibxgOIiqzHobB+IjBbwCUZ9MB/G3zFiE1IDPlh PBrzWEpbshPHRWC1Ws31mqUJYYklpgWWoC2GKVVjry2JnlrPKzT0w6L/w9m5w9pWDPjS 0O5vKxBnhY76/0tm6OLHFGBNseLpXOho8dtbhsOhdUbNE0HdvQB1CSun0WwWcYUpBjLq QgG+RdXi1WGUa7rCnW4EKRi0du6BnS5fzmLQbX/RsP8zDmW6Abjwv5us3ytCKwcbJWfu 2QKhhDRTMw1skD66SUuEwU3Hqp7fMMSlh3xxcBdiV131smdfSgHB+WzRZHe9d1N4JsQr jmGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ACBxtsWVb2OWpcnIOOtAMcXYGAqFOpXwv6cGgopBFYM=; b=WYR4SEqAB9pVBuU9+rrUAzFteEklAnOl+xhAGWp2rOzIiv7EI8+KehlwTcTS8edeOr 69rNp9Gwil1Z7zzWEwB6QY1gMUhi468pUZVXxYqZ2SgMPPGGpGdjJTG3ckkNa3Bdaf4J Y/hIG1M3Bqac4c9v+B9R3Yumkzjbsmy0j2aAlss6JOJYm/bwELjO81vdsdrxHCPyua39 MXIbtaGygHfMNIwWHpaDBhyfcPLaLeeJmk48Z6E6cOB+h6V0NoEqEl2wb0WbUqVePl6m 6KUKZwgMj2AKTs3Q4rzq70gnGLPJMbQv4GInhkjKtsHFJ+Ay10NRodlMeCJnTA8SeXgR lfvg== X-Gm-Message-State: APjAAAUiNg2YZXln1eLqjdd6PbWwJ7rHVOvgfYvoAvcISHufzthOEJVZ GNDhfNN94ODmWR/eclavd2spn81N9/1PfkKIVji7Ug== X-Google-Smtp-Source: APXvYqwhvCTcVcgMN/RdUc4auUsTdr7EJdnZ8JLNxmBTxcPl1V6FP73mX3Q1GY6fDNEbIXyPmuXePz1IvnIW8tzAXp0= X-Received: by 2002:aed:24af:: with SMTP id t44mr4231217qtc.57.1571670929269; Mon, 21 Oct 2019 08:15:29 -0700 (PDT) MIME-Version: 1.0 References: <20191017141305.146193-1-elver@google.com> <20191017141305.146193-3-elver@google.com> In-Reply-To: <20191017141305.146193-3-elver@google.com> From: Dmitry Vyukov Date: Mon, 21 Oct 2019 17:15:18 +0200 Message-ID: Subject: Re: [PATCH v2 2/8] objtool, kcsan: Add KCSAN runtime functions to whitelist To: Marco Elver Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , "Paul E. McKenney" , Peter Zijlstra , Thomas Gleixner , Will Deacon , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, "open list:KERNEL BUILD + fi..." , LKML , Linux-MM , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 17, 2019 at 4:13 PM Marco Elver wrote: > > This patch adds KCSAN runtime functions to the objtool whitelist. > > Signed-off-by: Marco Elver > --- > tools/objtool/check.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > index 044c9a3cb247..d1acc867b43c 100644 > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -466,6 +466,23 @@ static const char *uaccess_safe_builtin[] = { > "__asan_report_store4_noabort", > "__asan_report_store8_noabort", > "__asan_report_store16_noabort", > + /* KCSAN */ > + "__kcsan_check_watchpoint", > + "__kcsan_setup_watchpoint", > + /* KCSAN/TSAN out-of-line */ There is no TSAN in-line instrumentation. > + "__tsan_func_entry", > + "__tsan_func_exit", > + "__tsan_read_range", There is also __tsan_write_range(), right? Isn't it safer to add it right away? > + "__tsan_read1", > + "__tsan_read2", > + "__tsan_read4", > + "__tsan_read8", > + "__tsan_read16", > + "__tsan_write1", > + "__tsan_write2", > + "__tsan_write4", > + "__tsan_write8", > + "__tsan_write16", > /* KCOV */ > "write_comp_data", > "__sanitizer_cov_trace_pc", > -- > 2.23.0.866.gb869b98d4c-goog >