From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 093C2C352A3 for ; Mon, 10 Feb 2020 15:05:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1E3020658 for ; Mon, 10 Feb 2020 15:05:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mKWMlgmW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728966AbgBJPFD (ORCPT ); Mon, 10 Feb 2020 10:05:03 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:33419 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728742AbgBJPFC (ORCPT ); Mon, 10 Feb 2020 10:05:02 -0500 Received: by mail-qk1-f195.google.com with SMTP id h4so6831809qkm.0 for ; Mon, 10 Feb 2020 07:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8aliVfr/Np4hkPQ33o46u2Grd4DX7wASnGsm/Zcus3k=; b=mKWMlgmW4/67JTi5qgxd8v5tJFzgIpFofYvpPESc+RYnt/YLGM9XYgTLzPOTJsSq6z VXb90EUoAuQfvw6oke7+8Wsc6KqN/gWNwvR/7pWQjUh0Me2Cua7rWKp3SapilyDHZMho 4ex3uOyWGrka1ypF7FCNdpZ/cGsenXObj/OqHYivyN1GvTBB9lVr+7hTdtuiCD53YaxG r+3tYCLzpVXW1X63xGOvlIXjn6w9/tiRZjajhEI9S4Wc9IoDyszOm6sPvYYmDrjm/HOT mfquUK8dDbRpBekKzuajKGhf3mBU5Xw5Z6s3j5nwBKPD+oMSxk9cJk6OXVqS5GxmWbUk 5RcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8aliVfr/Np4hkPQ33o46u2Grd4DX7wASnGsm/Zcus3k=; b=cEw9uYVq6+ZQriEh4BZXc/7RxNlJRK26ufoNEP72pSloKSNSAqQmyyuLoO6xcQuTB1 eTe33EdA6cD+5CFaKNEj/gYkUAZlqv9rNtFTBXVuYkekXmXmn8GscV7wGzVguVclHMie /OOz+rpT7Vtq4Pta42HPDUoaulhgfBmU2tGZLTk0CdbTMhLPyRQeJ/bnK9JXbqCsxr4n fk+gy8ScapaEkdZvHoPiBPSJgMCMEV3IEJOjWSMPOgdEAXY3Q7nag40jMuvp2RwtpSjB w9xf+iRKFPpbA4lZdRRisRiS9p6aJRWKHXokj258NHLSws+QECORgx6BvS8e1n8n3MwF H1sw== X-Gm-Message-State: APjAAAWnePHSNgND7bk8d8DZroob3kyejD4j79dPawn6/7WW5DeT5eXU x/D4QHUD/qFmSOxA/6QJV3nyINA9Kdg2J+aPTxHpLA== X-Google-Smtp-Source: APXvYqy5WuodZaOQesAW4SGqZqJqlgDdTnhJCE8jQ98anEcysHXbU+RHZgiXMRVqFWVDMBL40gc8NrlEcUNRjtCS61M= X-Received: by 2002:a37:4755:: with SMTP id u82mr1692304qka.43.1581347101107; Mon, 10 Feb 2020 07:05:01 -0800 (PST) MIME-Version: 1.0 References: <0000000000003313f0058fea8435@google.com> <8736ek9qir.fsf@miraculix.mork.no> <1574159504.28617.5.camel@suse.de> <87pnho85h7.fsf@miraculix.mork.no> In-Reply-To: From: Dmitry Vyukov Date: Mon, 10 Feb 2020 16:04:47 +0100 Message-ID: Subject: Re: INFO: task hung in wdm_flush To: Tetsuo Handa Cc: Oliver Neukum , syzbot , Andrey Konovalov , Jia-Ju Bai , Sebastian Andrzej Siewior , Colin King , Greg Kroah-Hartman , LKML , USB list , syzkaller-bugs , yuehaibing@huawei.com, =?UTF-8?Q?Bj=C3=B8rn_Mork?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2020 at 1:46 PM Tetsuo Handa wrote: > > On 2020/02/10 19:09, Dmitry Vyukov wrote: > > You may also try on the exact commit the bug was reported, because > > usb-fuzzer is tracking branch, things may change there. > > OK. I explicitly tried > > #syz test: https://github.com/google/kasan.git e5cd56e94edde38ca4dafae5a450c5a16b8a5f23 > > but syzbot still cannot reproduce this bug using the reproducer... > > On 2020/02/10 21:02, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did not trigger crash: > > > > Reported-and-tested-by: syzbot+854768b99f19e89d7f81@syzkaller.appspotmail.com > > > > Tested on: > > > > commit: e5cd56e9 usb: gadget: add raw-gadget interface > > git tree: https://github.com/google/kasan.git > > kernel config: https://syzkaller.appspot.com/x/.config?x=c372cdb7140fc162 > > dashboard link: https://syzkaller.appspot.com/bug?extid=854768b99f19e89d7f81 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > Note: testing is done by a robot and is best-effort only. > > > > Anyway, I'm just suspecting that we are forgetting to wake up all waiters > after clearing WDM_IN_USE bit because sometimes multiple threads are reported > as hung. > > On 2020/02/10 15:27, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did not trigger crash: > > > > Reported-and-tested-by: syzbot+854768b99f19e89d7f81@syzkaller.appspotmail.com > > > > Tested on: > > > > commit: e5cd56e9 usb: gadget: add raw-gadget interface > > git tree: https://github.com/google/kasan.git usb-fuzzer > > kernel config: https://syzkaller.appspot.com/x/.config?x=c372cdb7140fc162 > > dashboard link: https://syzkaller.appspot.com/bug?extid=854768b99f19e89d7f81 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > patch: https://syzkaller.appspot.com/x/patch.diff?x=117c3ae9e00000 > > > > Note: testing is done by a robot and is best-effort only. > > > > On 2020/02/10 15:55, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did not trigger crash: > > > > Reported-and-tested-by: syzbot+854768b99f19e89d7f81@syzkaller.appspotmail.com > > > > Tested on: > > > > commit: e5cd56e9 usb: gadget: add raw-gadget interface > > git tree: https://github.com/google/kasan.git usb-fuzzer > > kernel config: https://syzkaller.appspot.com/x/.config?x=c372cdb7140fc162 > > dashboard link: https://syzkaller.appspot.com/bug?extid=854768b99f19e89d7f81 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > patch: https://syzkaller.appspot.com/x/patch.diff?x=13b3f6e9e00000 > > > > Note: testing is done by a robot and is best-effort only. > > > > On 2020/02/10 16:21, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did not trigger crash: > > > > Reported-and-tested-by: syzbot+854768b99f19e89d7f81@syzkaller.appspotmail.com > > > > Tested on: > > > > commit: e5cd56e9 usb: gadget: add raw-gadget interface > > git tree: https://github.com/google/kasan.git usb-fuzzer > > kernel config: https://syzkaller.appspot.com/x/.config?x=c372cdb7140fc162 > > dashboard link: https://syzkaller.appspot.com/bug?extid=854768b99f19e89d7f81 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > patch: https://syzkaller.appspot.com/x/patch.diff?x=115026b5e00000 > > > > Note: testing is done by a robot and is best-effort only. > > > > On 2020/02/10 16:44, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did not trigger crash: > > > > Reported-and-tested-by: syzbot+854768b99f19e89d7f81@syzkaller.appspotmail.com > > > > Tested on: > > > > commit: e5cd56e9 usb: gadget: add raw-gadget interface > > git tree: https://github.com/google/kasan.git usb-fuzzer > > kernel config: https://syzkaller.appspot.com/x/.config?x=c372cdb7140fc162 > > dashboard link: https://syzkaller.appspot.com/bug?extid=854768b99f19e89d7f81 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > patch: https://syzkaller.appspot.com/x/patch.diff?x=17285431e00000 > > > > Note: testing is done by a robot and is best-effort only. > > > > On 2020/02/10 17:05, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did not trigger crash: > > > > Reported-and-tested-by: syzbot+854768b99f19e89d7f81@syzkaller.appspotmail.com > > > > Tested on: > > > > commit: e5cd56e9 usb: gadget: add raw-gadget interface > > git tree: https://github.com/google/kasan.git usb-fuzzer > > kernel config: https://syzkaller.appspot.com/x/.config?x=c372cdb7140fc162 > > dashboard link: https://syzkaller.appspot.com/bug?extid=854768b99f19e89d7f81 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > Note: testing is done by a robot and is best-effort only. On Mon, Feb 10, 2020 at 4:03 PM Tetsuo Handa wrote: > > On 2020/02/10 21:46, Tetsuo Handa wrote: > > On 2020/02/10 19:09, Dmitry Vyukov wrote: > >> You may also try on the exact commit the bug was reported, because > >> usb-fuzzer is tracking branch, things may change there. > > > > OK. I explicitly tried > > > > #syz test: https://github.com/google/kasan.git e5cd56e94edde38ca4dafae5a450c5a16b8a5f23 > > > > but syzbot still cannot reproduce this bug using the reproducer... > > It seems that there is non-trivial difference between kernel config in dashboard > and kernel config in "syz test:" mails. Maybe that's the cause...