From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2D02C4363A for ; Wed, 28 Oct 2020 22:53:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70C7320735 for ; Wed, 28 Oct 2020 22:53:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eWofOYiP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389673AbgJ1Www (ORCPT ); Wed, 28 Oct 2020 18:52:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389662AbgJ1WwU (ORCPT ); Wed, 28 Oct 2020 18:52:20 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BEA8C0613CF for ; Wed, 28 Oct 2020 15:52:20 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id b69so558489qkg.8 for ; Wed, 28 Oct 2020 15:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zxgi7xd3nW4FDFVux6haRrdrCJvaqFEyqWtMMDIWgYY=; b=eWofOYiPw5raslm8yWSmDEwm/I/OMPVFw+0VduVEDahYCfRy1yswtr6sR1Pg/kenLL R03DZVGnmBJWhhFjsnQR4QiuVY3nJaLRrES5cmZvm0bRNyrAwWezG3L7l8+UdIqyus49 LINNaxfbFCakoHG0yD5FHsLcXhMzY+WpfQUIDFRnomSX+PG59G+pHRPJqMLCgdelEpZG 07W3oXzXJXs3omJoG1YIH6S3fhauMMlCn0CapNJ/QVH/EEBKI0o19EwatkaTOnkXUi2V hU9xEKAJFKdr1uoH4xOoA0pucS5Y3epFPk8cssZGA54e5xpUPnTTXvvc1B1+Xt5ENfgO Gz0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zxgi7xd3nW4FDFVux6haRrdrCJvaqFEyqWtMMDIWgYY=; b=NtvI5UAREATOVs0efZvGTApg1Pi8z7FPu+iJgkgISLxBLYKIdvKx9mHXxE+QPHHD1b dkjZMFHAapMsqLYpH16zK7DNtBQpVlxlNNi6VuzeoBoX87DzKywlNAzSLUiFsn8JtjgN 9HjcGCbgQeelLJqn1pihlsTacSU0INfhpjnbmQy0K1WiVvSk2PnFPE7ODGJN4H6Wo3uU w8AQ4NeH+GIu/CLuH4npk9WkD5rHDy6BHuINdY3B4ZTWl9J9lA3ePkuy+zTUPc+nDQ1G uMFUdVgvhCxbrNTmPbrrpy8iEPLOXxb9jrx7G71d6Hk8XTAHYXLAe8vgy9PDxQc17Lg7 6ZQQ== X-Gm-Message-State: AOAM533MOeVv9JI0zDM+q3yBUKEgc2ULsEtzWCT/XxuUajgOCd9fhTJP CUqZrlALQBU7sYtIjeuLehTh932s25wSgibpOutAnCUBe7TQaA== X-Google-Smtp-Source: ABdhPJy50POtHGn57238IQURdi1vWUPLZnjnOkGTn4fmZdTNYDz3IxwV1tq5IiPRk78U+K6fH4jLx8yuea6oPQZvVgw= X-Received: by 2002:a37:7b44:: with SMTP id w65mr8409031qkc.350.1603904264037; Wed, 28 Oct 2020 09:57:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Vyukov Date: Wed, 28 Oct 2020 17:57:33 +0100 Message-ID: Subject: Re: [PATCH RFC v2 17/21] kasan: simplify kasan_poison_kfree To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2020 at 3:20 PM Andrey Konovalov wrote: > > kasan_poison_kfree() is currently only called for mempool allocations > that are backed by either kmem_cache_alloc() or kmalloc(). Therefore, the > page passed to kasan_poison_kfree() is always PageSlab() and there's no > need to do the check. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/If31f88726745da8744c6bea96fb32584e6c2778c Reviewed-by: Dmitry Vyukov > --- > mm/kasan/common.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index a581937c2a44..b82dbae0c5d6 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -441,16 +441,7 @@ void __kasan_poison_kfree(void *ptr, unsigned long ip) > struct page *page; > > page = virt_to_head_page(ptr); > - > - if (unlikely(!PageSlab(page))) { > - if (ptr != page_address(page)) { > - kasan_report_invalid_free(ptr, ip); > - return; > - } > - kasan_poison_memory(ptr, page_size(page), KASAN_FREE_PAGE); > - } else { > - ____kasan_slab_free(page->slab_cache, ptr, ip, false); > - } > + ____kasan_slab_free(page->slab_cache, ptr, ip, false); > } > > void __kasan_kfree_large(void *ptr, unsigned long ip) > -- > 2.29.0.rc1.297.gfa9743e501-goog >