From: Dmitry Vyukov <dvyukov@google.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
syzbot <syzbot+56f9673bb4cdcbeb0e92@syzkaller.appspotmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Souptick Joarder <jrdr.linux@gmail.com>,
Kees Cook <keescook@chromium.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
Thomas Gleixner <tglx@linutronix.de>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: possible deadlock in mon_bin_vma_fault
Date: Fri, 22 Nov 2019 08:18:28 +0100 [thread overview]
Message-ID: <CACT4Y+bsZP4G7LXNzZ2OWLFUUYSQT+xRC48i0hzquJrrCVqhwA@mail.gmail.com> (raw)
In-Reply-To: <20191121173825.1527c3a5@suzdal.zaitcev.lan>
On Fri, Nov 22, 2019 at 12:38 AM Pete Zaitcev <zaitcev@redhat.com> wrote:
>
> On Thu, 21 Nov 2019 11:20:20 -0500 (EST)
> Alan Stern <stern@rowland.harvard.edu> wrote:
>
> > On Thu, 21 Nov 2019, Pete Zaitcev wrote:
> >
> > > Anyway... If you are looking at it too, what do you think about not using
> > > any locks in mon_bin_vma_fault() at all? Isn't it valid? I think I tried
> > > to be "safe", but it only uses things that are constants unless we're
> > > opening and closing; a process cannot make page faults unless it has
> > > some thing mapped; and that is only possible if device is open and stays
> > > open. Can you find a hole in this reasoning?
> >
> > I think you're right. [...]
>
> How about the appended patch, then? You like?
>
> Do you happen to know how to refer to a syzbot report in a commit message?
>
> -- Pete
>
> commit 628f3bbf37eee21cce4cfbfaa6a796b129d7736d
> Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
> Date: Thu Nov 21 17:24:00 2019 -0600
>
> usb: Fix a deadlock in usbmon between mmap and read
>
> Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
/\/\/\/\/\/\/\/\/\/\
Please don't forget the Reported-by
> diff --git a/drivers/usb/mon/mon_bin.c b/drivers/usb/mon/mon_bin.c
> index ac2b4fcc265f..fb7df9810bad 100644
> --- a/drivers/usb/mon/mon_bin.c
> +++ b/drivers/usb/mon/mon_bin.c
> @@ -1039,12 +1039,18 @@ static long mon_bin_ioctl(struct file *file, unsigned int cmd, unsigned long arg
>
> mutex_lock(&rp->fetch_lock);
> spin_lock_irqsave(&rp->b_lock, flags);
> - mon_free_buff(rp->b_vec, rp->b_size/CHUNK_SIZE);
> - kfree(rp->b_vec);
> - rp->b_vec = vec;
> - rp->b_size = size;
> - rp->b_read = rp->b_in = rp->b_out = rp->b_cnt = 0;
> - rp->cnt_lost = 0;
> + if (rp->mmap_active) {
> + mon_free_buff(vec, size/CHUNK_SIZE);
> + kfree(vec);
> + ret = -EBUSY;
> + } else {
> + mon_free_buff(rp->b_vec, rp->b_size/CHUNK_SIZE);
> + kfree(rp->b_vec);
> + rp->b_vec = vec;
> + rp->b_size = size;
> + rp->b_read = rp->b_in = rp->b_out = rp->b_cnt = 0;
> + rp->cnt_lost = 0;
> + }
> spin_unlock_irqrestore(&rp->b_lock, flags);
> mutex_unlock(&rp->fetch_lock);
> }
> @@ -1093,11 +1099,11 @@ static long mon_bin_ioctl(struct file *file, unsigned int cmd, unsigned long arg
> return ret;
> if (put_user(ret, &uptr->nfetch))
> return -EFAULT;
> - ret = 0;
> }
> break;
>
> - case MON_IOCG_STATS: {
> + case MON_IOCG_STATS:
> + {
> struct mon_bin_stats __user *sp;
> unsigned int nevents;
> unsigned int ndropped;
> @@ -1113,7 +1119,6 @@ static long mon_bin_ioctl(struct file *file, unsigned int cmd, unsigned long arg
> return -EFAULT;
> if (put_user(nevents, &sp->queued))
> return -EFAULT;
> -
> }
> break;
>
> @@ -1216,13 +1221,21 @@ mon_bin_poll(struct file *file, struct poll_table_struct *wait)
> static void mon_bin_vma_open(struct vm_area_struct *vma)
> {
> struct mon_reader_bin *rp = vma->vm_private_data;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&rp->b_lock, flags);
> rp->mmap_active++;
> + spin_unlock_irqrestore(&rp->b_lock, flags);
> }
>
> static void mon_bin_vma_close(struct vm_area_struct *vma)
> {
> + unsigned long flags;
> +
> struct mon_reader_bin *rp = vma->vm_private_data;
> + spin_lock_irqsave(&rp->b_lock, flags);
> rp->mmap_active--;
> + spin_unlock_irqrestore(&rp->b_lock, flags);
> }
>
> /*
> @@ -1234,16 +1247,12 @@ static vm_fault_t mon_bin_vma_fault(struct vm_fault *vmf)
> unsigned long offset, chunk_idx;
> struct page *pageptr;
>
> - mutex_lock(&rp->fetch_lock);
> offset = vmf->pgoff << PAGE_SHIFT;
> - if (offset >= rp->b_size) {
> - mutex_unlock(&rp->fetch_lock);
> + if (offset >= rp->b_size)
> return VM_FAULT_SIGBUS;
> - }
> chunk_idx = offset / CHUNK_SIZE;
> pageptr = rp->b_vec[chunk_idx].pg;
> get_page(pageptr);
> - mutex_unlock(&rp->fetch_lock);
> vmf->page = pageptr;
> return 0;
> }
>
> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/20191121173825.1527c3a5%40suzdal.zaitcev.lan.
next prev parent reply other threads:[~2019-11-22 7:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 22:01 possible deadlock in mon_bin_vma_fault syzbot
2019-11-20 12:01 ` syzbot
2019-11-20 16:14 ` Alan Stern
2019-11-20 17:12 ` Pete Zaitcev
2019-11-20 18:47 ` Alan Stern
2019-11-21 14:48 ` Pete Zaitcev
2019-11-21 16:20 ` Alan Stern
2019-11-21 16:46 ` Pete Zaitcev
2019-11-21 23:38 ` Pete Zaitcev
2019-11-22 7:18 ` Dmitry Vyukov [this message]
2019-11-22 15:27 ` Alan Stern
2019-11-22 20:52 ` Pete Zaitcev
2019-11-22 22:13 ` Alan Stern
2019-11-22 22:13 ` syzbot
2019-11-23 17:18 ` Alan Stern
2019-11-23 17:18 ` syzbot
2019-11-24 15:59 ` Alan Stern
2019-11-24 19:10 ` syzbot
2019-11-24 20:55 ` Alan Stern
2019-11-24 23:24 ` syzbot
2019-11-25 0:10 ` Pete Zaitcev
2019-11-25 2:12 ` Alan Stern
2019-11-23 17:18 ` Re: " syzbot
2019-11-22 22:13 ` syzbot
2019-11-20 17:33 ` Pete Zaitcev
2019-11-20 18:18 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+bsZP4G7LXNzZ2OWLFUUYSQT+xRC48i0hzquJrrCVqhwA@mail.gmail.com \
--to=dvyukov@google.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+56f9673bb4cdcbeb0e92@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).