From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A984C4708F for ; Tue, 1 Jun 2021 09:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 023AE61375 for ; Tue, 1 Jun 2021 09:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233672AbhFAJII (ORCPT ); Tue, 1 Jun 2021 05:08:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44258 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231139AbhFAJIF (ORCPT ); Tue, 1 Jun 2021 05:08:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622538383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TC49diZ8yvtNeRfoDHho9BsiKWB6WeW1SJE0j6cAKdU=; b=LNzbskb221IDRNS7eTBI68JLiDh5WxTN4LJUgYjQqz0GmpLWYurltMapETTHgP7Z9XwqzF dWeM4EnII/wJUkBniwFY0wsMq5g9EXSyCc0jjfvq8O7VLpJFb3AWPc1k4Gcu6NqaTMnAw/ 0iKiUzZaUkRri/f0bb21wRBZnKSDsuE= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-prgU9vUpOtuPQ8zbzrzZ4A-1; Tue, 01 Jun 2021 05:06:22 -0400 X-MC-Unique: prgU9vUpOtuPQ8zbzrzZ4A-1 Received: by mail-il1-f199.google.com with SMTP id z3-20020a92cb830000b02901bb45557893so9630741ilo.18 for ; Tue, 01 Jun 2021 02:06:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=TC49diZ8yvtNeRfoDHho9BsiKWB6WeW1SJE0j6cAKdU=; b=BgnxDgrHsXke/qI2RGsL6/OapbQ6JL49QFdOCd+EAOTjqaHZl5OwFfpuEtbomz6iNU Yf0aA+vnU/y7YyHqoK8LwsQahhyV0ymXmYv+G/O1f7Va7rYJ5XVhVr4wKVWsMvHzGth9 c6pGxLAz20p6X6/1DpSxwTbxR+iodFy6Rh/Q1Gt8BH241zs6ML5N+gC3Mc2RnaNe+BiC fwzQSwEdePR0eiO78DZv/QD2Hjr36ZgZzqB+D5aVivphvD0FXb7YxA/kwixqONMVk3KI Ea8N9DuvwyHYkZ/taxfovyAjQT61ZuMnuZXYUSdbm8qJWOSZxtFOkJTtfnyZKBrCaBE7 YD4A== X-Gm-Message-State: AOAM531drwxG+uOEMsIP5QSkoVYhC9Va0+fDqPTznQ3DRSMG7uIQm77b fZr6K1Woo5E3Zmjt5r1n6x0R60jtaCYaMpVIK9nndhl+Gr0zB15NK7fgVadDeYU3MvAYrQc115v V8j6rnd+VwmLbcIFQc9psyOlMEDyL49/EW6raxn8K X-Received: by 2002:a02:384b:: with SMTP id v11mr11232989jae.90.1622538382157; Tue, 01 Jun 2021 02:06:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZQ8URK5CiJvEC5yEjY6vdL8Z9nhAdkHGrPEoD8pjNhf2DMrUcABocCKqqN/gaPUGnJjPa/rOI/2sHGIkGGqQ= X-Received: by 2002:a02:384b:: with SMTP id v11mr11232977jae.90.1622538382042; Tue, 01 Jun 2021 02:06:22 -0700 (PDT) MIME-Version: 1.0 References: <20210511070257.7843-1-ihuguet@redhat.com> In-Reply-To: <20210511070257.7843-1-ihuguet@redhat.com> From: =?UTF-8?B?w43DsWlnbyBIdWd1ZXQ=?= Date: Tue, 1 Jun 2021 11:06:11 +0200 Message-ID: Subject: Re: [PATCH] BRCM80211: improve readability on addresses copy To: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 9:04 AM =C3=8D=C3=B1igo Huguet = wrote: > > A static analyzer identified as a potential bug the copy of > 12 bytes from a 6 bytes array to a 6 bytes array. Both > arrays are 6 bytes addresses. > > Although not being a real bug, it is not immediately clear > why is done this way: next 6 bytes address, contiguous to > the first one, must also be copied to next contiguous 6 bytes > address of the destination. > > Copying each one separately will make both static analyzers > and reviewers happier. > > Signed-off-by: =C3=8D=C3=B1igo Huguet > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/dr= ivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c > index 763e0ec583d7..26de1bd7fee9 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c > @@ -6607,7 +6607,8 @@ brcms_c_d11hdrs_mac80211(struct brcms_c_info *wlc, = struct ieee80211_hw *hw, > rts->frame_control =3D cpu_to_le16(IEEE80211_FTYP= E_CTL | > IEEE80211_STYPE_= RTS); > > - memcpy(&rts->ra, &h->addr1, 2 * ETH_ALEN); > + memcpy(&rts->ra, &h->addr1, ETH_ALEN); > + memcpy(&rts->ta, &h->addr2, ETH_ALEN); > } > > /* mainrate > -- > 2.31.1 > Hello, About 3 weeks ago I sent this patch, just with a small style change proposal. Any feedback would be appreciated. Thanks! --=20 =C3=8D=C3=B1igo Huguet