From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E5CC433DB for ; Sat, 6 Feb 2021 04:14:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73C0F64F05 for ; Sat, 6 Feb 2021 04:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbhBFEN6 (ORCPT ); Fri, 5 Feb 2021 23:13:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232195AbhBFCzT (ORCPT ); Fri, 5 Feb 2021 21:55:19 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8486C061793 for ; Fri, 5 Feb 2021 14:02:16 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id f6so8762442ioz.5 for ; Fri, 05 Feb 2021 14:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gn1oNPUt8nvKg4L8IQuJxo3ItPqw1Pp9dP3UEdFlsnw=; b=KZn95LUJ9txktXDozvtFRm5+TW+2VTONYEJDyg6QieKJl3x34oVwgzLKvT7wNDaJwJ 4dag3d62fE59CkIGJx2aw4CLaBC/gAj/r3y9yS6QPqVu388tGzV7Hnpgff9+opScocqL mHZ7CGk0SkZhFmtnrbIDwTI/5jUUaFYApGJ3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gn1oNPUt8nvKg4L8IQuJxo3ItPqw1Pp9dP3UEdFlsnw=; b=i/WBf8qpujwy2aDVcWd09VrXJW13TLU+HJa5/K7N2GiVRflx2osMOzyUJA3dKr8vfw ZLIkoahz7JbRZoDX542mDyVg6lSPo7mVC13+AvXcfe2b0ADD4G4hIOQr4HtBN6PRGw3H NK4zfRs1Q/A9LTJBgleexEjGtTMma6zsRLzpWJudMgUnUnb2p13/5V8wrGoJFbPZ8CGf aRb5tUkPXQlG4jRhj/1uGqf5B/MnKzLBaVvkRYL1pASgUh7AjiKmdN7ODKnzq90ivwKf +6PWwMPwOWkn6ox++JJoQyDD0btMtz3RX4SflGgXljZxCa9LQPM48rMM+CbKgElKdZ9O K3/w== X-Gm-Message-State: AOAM532/VtphCCc3c4hywTOBGQJVoGicQtiCBL9UdpywY4TJ8uSyRlRq B1TcOzFQctbzsPcZeV3IeiKEmXIwL8FZ1PIj/0UtFg== X-Google-Smtp-Source: ABdhPJzm1U46fzzVZVO4LDJ7oGLxGsIxOuGbM8B5KCv3grFD0fHVbdW8c8ZD7RfP3BSJaecLpRgAkvts/ULuG+Nq7Xk= X-Received: by 2002:a02:1649:: with SMTP id a70mr6798927jaa.97.1612562534776; Fri, 05 Feb 2021 14:02:14 -0800 (PST) MIME-Version: 1.0 References: <20201215173021.5884-1-youghand@codeaurora.org> In-Reply-To: <20201215173021.5884-1-youghand@codeaurora.org> From: Abhishek Kumar Date: Fri, 5 Feb 2021 14:02:04 -0800 Message-ID: Subject: Re: [PATCH 1/3] cfg80211: Add wiphy flag to trigger STA disconnect after hardware restart To: Youghandhar Chintala Cc: Johannes Berg , "David S. Miller" , Jakub Kicinski , linux-wireless , netdev , LKML , Douglas Anderson , Brian Norris , Rakesh Pillai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org LGTM! If no one has any objections, I would be happy to see this considered for upstream. Reviewed-by: Abhishek Kumar Thanks Abhishek On Tue, Dec 15, 2020 at 9:30 AM Youghandhar Chintala wrote: > > Many wifi drivers (e.g. ath10k using qualcomm wifi chipsets) > support silent target hardware restart/recovery. Out of these > drivers which support target hw restart, certain chipsets > have the wifi mac sequence number addition for transmitted > frames done by the firmware. For such chipsets, a silent > target hardware restart breaks the continuity of the wifi > mac sequence number, since the wifi mac sequence number > restarts from 0 after the restart, which in-turn leads > to the peer access point dropping all the frames from device > until it receives the frame with the mac sequence which was > expected by the AP. > > Add a wiphy flag for the driver to indicate that it needs a > trigger for STA disconnect after hardware restart. > > Tested on ath10k using WCN3990, QCA6174. > > Signed-off-by: Youghandhar Chintala > --- > include/net/cfg80211.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index ab249ca..7fba6f6 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -4311,6 +4311,9 @@ struct cfg80211_ops { > * @WIPHY_FLAG_HAS_STATIC_WEP: The device supports static WEP key installation > * before connection. > * @WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK: The device supports bigger kek and kck keys > + * @WIPHY_FLAG_STA_DISCONNECT_ON_HW_RESTART: The device needs a trigger to > + * disconnect STA after target hardware restart. This flag should be > + * exposed by drivers which support target recovery. > */ > enum wiphy_flags { > WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK = BIT(0), > @@ -4337,6 +4340,7 @@ enum wiphy_flags { > WIPHY_FLAG_SUPPORTS_5_10_MHZ = BIT(22), > WIPHY_FLAG_HAS_CHANNEL_SWITCH = BIT(23), > WIPHY_FLAG_HAS_STATIC_WEP = BIT(24), > + WIPHY_FLAG_STA_DISCONNECT_ON_HW_RESTART = BIT(25), > }; > > /** > -- > 2.7.4 >