From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbcFGCt0 (ORCPT ); Mon, 6 Jun 2016 22:49:26 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:41364 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbcFGCtY (ORCPT ); Mon, 6 Jun 2016 22:49:24 -0400 MIME-Version: 1.0 In-Reply-To: <1465265115-12479-1-git-send-email-mnghuan@gmail.com> References: <1465265115-12479-1-git-send-email-mnghuan@gmail.com> From: Ming Lei Date: Tue, 7 Jun 2016 10:49:21 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] loop: Make user notify for adding loop device failed To: Minfei Huang Cc: Jens Axboe , Al Viro , Jeff Moyer , Sagi Grimberg , Miklos Szeredi , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 7, 2016 at 10:05 AM, Minfei Huang wrote: > There is no error number returned if loop driver fails in function > alloc_disk to add new loop device. Add a correct error number to make > user notify in this case. > > Signed-off-by: Minfei Huang Good catch! Reviewed-by: Ming Lei > --- > drivers/block/loop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 1fa8cc2..2caaf6f 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1765,6 +1765,7 @@ static int loop_add(struct loop_device **l, int i) > */ > queue_flag_set_unlocked(QUEUE_FLAG_NOMERGES, lo->lo_queue); > > + err = -ENOMEM; > disk = lo->lo_disk = alloc_disk(1 << part_shift); > if (!disk) > goto out_free_queue; > -- > 2.7.4 (Apple Git-66) >