From: Ming Lei <ming.lei@canonical.com>
To: eranian@gmail.com
Cc: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
David Long <dave.long@linaro.org>,
b-cousson@ti.com, mans@mansr.com, will.deacon@arm.com,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: oprofile and ARM A9 hardware counter
Date: Wed, 8 Feb 2012 10:24:00 +0800 [thread overview]
Message-ID: <CACVXFVMx9Zx3ZQr6Q-17x5NVL8iuBJjOjtw39FJiWX=fGkZNZA@mail.gmail.com> (raw)
In-Reply-To: <CAMsRxfJH+9MS=Svmh0BvDSb8xqsPe2HPobkeKcn8JO35npjhwQ@mail.gmail.com>
Hi,
CC lkml and perf guys, since looks it is related with perf core.
On Tue, Feb 7, 2012 at 7:59 PM, stephane eranian <eranian@googlemail.com> wrote:
> An easier way to verify we're getting the right number of samples is
> to use perf top:
>
> $ taskset -c 1 noploop 1000 &
> $ sudo perf top
>
> You'll see around 850 irqs/sec, should be closer to 1000.
> But if I drop the rate to 100Hz, then it works:
>
> $ sudo perf top -F 100
>
> That leads me to believe there is too much overhead somewhere.
> Could be in perf_event itself.
Looks like the issue is caused by perf_event itself, but nothing to do
with much overhead
somewhere.
On OMAP4, HZ is 128, and perf_rotate_context may set a new sample period(~8ms),
which is much longer than 1ms in 1000HZ freq mode, so less sample events are
observed. X86 isn't affected since its HZ is 1000.
With patch[1], about 10000 sample events can be generated after running
'perf record -e cycles ./noploop 10' and 'perf report -D | tail -20'
on panda board.
I am not sure if patch[1] is a right fix, but it can verify the problem.
thanks,
--
Ming Lei
[1], fix adjusting frequency in perf_rotate_context
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 32b48c8..db4faf2 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2300,14 +2300,12 @@ do { \
return div64_u64(dividend, divisor);
}
-static void perf_adjust_period(struct perf_event *event, u64 nsec, u64 count)
+static void perf_adjust_period(struct perf_event *event, u64 period, u64 count)
{
struct hw_perf_event *hwc = &event->hw;
- s64 period, sample_period;
+ s64 sample_period;
s64 delta;
- period = perf_calculate_period(event, nsec, count);
-
delta = (s64)(period - hwc->sample_period);
delta = (delta + 7) / 8; /* low pass filter */
@@ -2363,8 +2361,13 @@ static void perf_ctx_adjust_freq(struct
perf_event_context *ctx, u64 period)
delta = now - hwc->freq_count_stamp;
hwc->freq_count_stamp = now;
- if (delta > 0)
+ if (delta > 0) {
+ period = perf_calculate_period(event, period, delta);
+
+ if (period > 4*hwc->sample_period)
+ period = hwc->sample_period;
perf_adjust_period(event, period, delta);
+ }
}
}
@@ -4533,8 +4536,10 @@ static int __perf_event_overflow(struct
perf_event *event,
hwc->freq_time_stamp = now;
- if (delta > 0 && delta < 2*TICK_NSEC)
+ if (delta > 0 && delta < 2*TICK_NSEC) {
+ delta = perf_calculate_period(event, delta, hwc->last_period);
perf_adjust_period(event, delta, hwc->last_period);
+ }
}
/*
next parent reply other threads:[~2012-02-08 2:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1328578047.1724.17.camel@dave-Dell-System-XPS-L502X>
[not found] ` <CAMQu2gwfo5JXAqQaLUNs7C7J3TUhEO2zOcyD0Rk-D_O61Yrfag@mail.gmail.com>
[not found] ` <CAMsRxfLNBbQO5XF+EHJqNsnW+s=ay3mjSV5dh=sxdwzktUu03g@mail.gmail.com>
[not found] ` <CAMQu2gzfNAwtf1c6jrTZpfGMSqBgBrQKmFTeCFzbvMh9ESBDUg@mail.gmail.com>
[not found] ` <CAMsRxfKR1ODH56BtcUT5Dv6qOVEYGVheEcW9ugXsZmLKok==bg@mail.gmail.com>
[not found] ` <CAMQu2gwWt6oQPjxc1YHgOoxVkHdck_q78Xf==7ncwRj0_uS-JQ@mail.gmail.com>
[not found] ` <CAMQu2gyCPtbNfBa5V8ve2JORN+sDeAY+hvR0g0_9U354JgcuiA@mail.gmail.com>
[not found] ` <CAMsRxfJVEgVJoHcaPQbMg5mwz=tZUce4oibDUxtnevSF8bGY9g@mail.gmail.com>
[not found] ` <CAMQu2gxVUqDF2HkPD=QeX0N_tUd=9FTd+T+1LHCR0tsCgQxC8Q@mail.gmail.com>
[not found] ` <CAMsRxfJH+9MS=Svmh0BvDSb8xqsPe2HPobkeKcn8JO35npjhwQ@mail.gmail.com>
2012-02-08 2:24 ` Ming Lei [this message]
2012-02-15 16:38 ` oprofile and ARM A9 hardware counter Peter Zijlstra
2012-02-16 10:25 ` Ming Lei
2012-02-16 15:00 ` Will Deacon
2012-02-16 16:12 ` Ming Lei
2012-02-16 16:19 ` Peter Zijlstra
2012-02-16 16:37 ` Ming Lei
2012-02-16 18:08 ` Will Deacon
2012-02-17 5:24 ` Ming Lei
2012-02-17 10:26 ` Will Deacon
2012-02-20 3:19 ` Ming Lei
2012-02-20 9:44 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACVXFVMx9Zx3ZQr6Q-17x5NVL8iuBJjOjtw39FJiWX=fGkZNZA@mail.gmail.com' \
--to=ming.lei@canonical.com \
--cc=a.p.zijlstra@chello.nl \
--cc=b-cousson@ti.com \
--cc=dave.long@linaro.org \
--cc=eranian@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=mingo@elte.hu \
--cc=santosh.shilimkar@ti.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).