From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751057AbdAQCkp (ORCPT ); Mon, 16 Jan 2017 21:40:45 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35364 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbdAQCkk (ORCPT ); Mon, 16 Jan 2017 21:40:40 -0500 MIME-Version: 1.0 In-Reply-To: <20170116151813.GA28410@infradead.org> References: <1482854250-13481-1-git-send-email-tom.leiming@gmail.com> <20170116151813.GA28410@infradead.org> From: Ming Lei Date: Tue, 17 Jan 2017 10:40:36 +0800 Message-ID: Subject: Re: [PATCH v1 00/54] block: support multipage bvec To: Christoph Hellwig Cc: Jens Axboe , Linux Kernel Mailing List , linux-block , Al Viro , Andrew Morton , Kent Overstreet Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 11:18 PM, Christoph Hellwig wrote: > On Mon, Jan 16, 2017 at 11:19:19AM +0800, Ming Lei wrote: >> Any comments on this version? > > We'll need to make sure all drivers can handle multi-page bvecs > before continuing any other work. Without that the series is a no-go. > Note that in general making a drivers capable of handling multipage > bvecs will clean it up by using new helpers and be worthwhile on it's > own. IMO, the only one left is raid(1/5/10) which can be dealt with by the "NO_MP" flag. This point can be observed by result from runnig 'git grep': $git grep -n -E "bi_vcnt|bi_io_vec" ./ Also this patchset addes comment in cases of direct access to bvec table, and the cases have been minimized too, and most of them are single bvec based. Thanks, Ming Lei