From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbcBUV3v (ORCPT ); Sun, 21 Feb 2016 16:29:51 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:47404 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbcBUV3t (ORCPT ); Sun, 21 Feb 2016 16:29:49 -0500 MIME-Version: 1.0 In-Reply-To: <3A47B4705F6BE24CBB43C61AA73286211B3AA6A9@SSIEXCH-MB3.ssi.samsung.com> References: <20151211104937.GA23165@amd> <20151211140841.GA22873@redhat.com> <20160220174035.GA16459@amd> <20160220184258.GA3753@amd> <20160220195136.GA27149@redhat.com> <20160220200432.GB22120@amd> <20160220203856.GB27149@redhat.com> <20160220205519.GA14108@amd> <20160221041540.GA24735@kmo-pixel> <3A47B4705F6BE24CBB43C61AA73286211B3AA6A9@SSIEXCH-MB3.ssi.samsung.com> Date: Sun, 21 Feb 2016 17:40:59 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: 4.4-final: 28 bioset threads on small notebook From: Ming Lei To: Ming Lin-SSI Cc: Kent Overstreet , Pavel Machek , Mike Snitzer , kernel list , "axboe@fb.com" , "hch@lst.de" , "neilb@suse.de" , "martin.petersen@oracle.com" , "dpark@posteo.net" , "dm-devel@redhat.com" , "agk@redhat.com" , "jkosina@suse.cz" , "geoff@infradead.org" , "jim@jtan.com" , "pjk1939@linux.vnet.ibm.com" , "minchan@kernel.org" , "ngupta@vflare.org" , "oleg.drokin@intel.com" , "andreas.dilger@intel.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 21, 2016 at 2:43 PM, Ming Lin-SSI wrote: >>-----Original Message----- > > So it's almost already "per request_queue" Yes, that is because of the following line: q->bio_split = bioset_create(BIO_POOL_SIZE, 0); in blk_alloc_queue_node(). Looks like this bio_set doesn't need to be per-request_queue, and now it is only used for fast-cloning bio for splitting, and one global split bio_set should be enough. thanks, Ming