From: Alexey Dobriyan <adobriyan@gmail.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Emese Revfy <re.emese@gmail.com>, Pax Team <pageexec@freemail.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
Mateusz Guzik <mguzik@redhat.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Jarod Wilson <jarod@redhat.com>
Subject: Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready
Date: Fri, 29 Apr 2016 13:25:24 +0300 [thread overview]
Message-ID: <CACVxJT_mZhX7G7q31WW+EY_sT-KJXFDnQ29j0D1YF6Nba_Ld3g@mail.gmail.com> (raw)
In-Reply-To: <CA+rthh98mYF8heKzEN6Y28ATgjXL54_i6DTKpRV4B52r3hmofA@mail.gmail.com>
On Fri, Apr 29, 2016 at 9:02 AM, Mathias Krause <minipli@googlemail.com> wrote:
> On 28 April 2016 at 23:30, Andrew Morton <akpm@linux-foundation.org> wrote:
>> On Thu, 28 Apr 2016 21:04:18 +0200 Mathias Krause <minipli@googlemail.com> wrote:
>>
>>> If /proc/<PID>/environ gets read before the envp[] array is fully set
>>> up in create_{aout,elf,elf_fdpic,flat}_tables(), we might end up trying
>>> to read more bytes than are actually written, as env_start will already
>>> be set but env_end will still be zero, making the range calculation
>>> underflow, allowing to read beyond the end of what has been written.
>>>
>>> Fix this as it is done for /proc/<PID>/cmdline by testing env_end for
>>> zero. It is, apparently, intentionally set last in create_*_tables().
>>
>> Also, if this is indeed our design then
>>
>> a) the various create_*_tables() should have comments in there which
>> explain this subtlety to the reader. Or, better, they use a common
>> helper function for this readiness-signaling operation because..
>>
>> b) we'll need some barriers there to ensure that the environ_read()
>> caller sees the create_*_tables() writes in the correct order.
>
> I totally agree that this kind of "synchronization" is rather fragile.
> Adding comments won't help much, I fear. Rather a dedicated flag,
> signaling "process ready for inspection" may be needed. So far, that's
> what env_end is (ab-)used for.
If MM Cabal is OK with MMF_LOAD_BINARY_OK flag
applied at search_binary_handler(), it should work for /proc .
Alexey
prev parent reply other threads:[~2016-04-29 10:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 19:04 [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready Mathias Krause
2016-04-28 19:20 ` Mateusz Guzik
2016-04-28 19:36 ` Mathias Krause
2016-04-29 10:11 ` Alexey Dobriyan
2016-04-28 19:28 ` Cyrill Gorcunov
2016-04-28 21:26 ` Andrew Morton
2016-04-29 5:59 ` Mathias Krause
2016-04-28 21:30 ` Andrew Morton
2016-04-29 6:02 ` Mathias Krause
2016-04-29 10:25 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACVxJT_mZhX7G7q31WW+EY_sT-KJXFDnQ29j0D1YF6Nba_Ld3g@mail.gmail.com \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=minipli@googlemail.com \
--cc=pageexec@freemail.hu \
--cc=re.emese@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).