From: Sandy Harris <sandyinchina@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 1/8] Replace memset() with memzero_explicit()
Date: Tue, 16 Nov 2021 19:25:22 +0800 [thread overview]
Message-ID: <CACXcFm=kwziZ5Etdevu0uq_t5qy0NbGY753WfLvnwkMqtU9Tvg@mail.gmail.com> (raw)
Replace memset(address,0,bytes) which may be optimised away
with memzero_explicit(address,bytes) which resists
such optimisation
---
crypto/des_generic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/des_generic.c b/crypto/des_generic.c
index c85354a5e94c..105a32e7afea 100644
--- a/crypto/des_generic.c
+++ b/crypto/des_generic.c
@@ -30,7 +30,7 @@ static int des_setkey(struct crypto_tfm *tfm, const u8 *key,
err = 0;
}
if (err)
- memset(dctx, 0, sizeof(*dctx));
+ memzero_explicit(dctx, sizeof(*dctx));
return err;
}
@@ -62,7 +62,7 @@ static int des3_ede_setkey(struct crypto_tfm *tfm,
const u8 *key,
err = 0;
}
if (err)
- memset(dctx, 0, sizeof(*dctx));
+ memzero_explicit(dctx, sizeof(*dctx));
return err;
}
--
next reply other threads:[~2021-11-16 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 11:25 Sandy Harris [this message]
2021-11-16 11:49 ` [PATCH 1/8] Replace memset() with memzero_explicit() Greg Kroah-Hartman
2021-11-16 11:50 ` Greg Kroah-Hartman
2021-11-16 12:52 ` Greg Kroah-Hartman
2021-11-17 3:08 ` Sandy Harris
2021-11-17 6:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACXcFm=kwziZ5Etdevu0uq_t5qy0NbGY753WfLvnwkMqtU9Tvg@mail.gmail.com' \
--to=sandyinchina@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).