From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C82C433E6 for ; Wed, 20 Jan 2021 13:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28CEE23357 for ; Wed, 20 Jan 2021 13:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731544AbhATNXC (ORCPT ); Wed, 20 Jan 2021 08:23:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:53534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730970AbhATNPX (ORCPT ); Wed, 20 Jan 2021 08:15:23 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 620E323380 for ; Wed, 20 Jan 2021 13:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611148479; bh=/Dib82sU5arH2pQ+ODWj2A/H3qlrgt26ReauOPltmfs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=A0ujDq6LP+USWQhT5cpJn2rJU+bT1xQmLFDRgP2HuT6cSDLJahRAshL0DZUkmaEV9 RXwHGyhwsktLXiJnVyaMk40vcrfpo44ydNOx5rTHSlcyls0bcSiq5RdSmsXJFd4Dii qMjB4mw7U6AHpmbhbHzCcSA2ducAd1fLHoOPVjw/GACi4Mk/u2llEGr0XfqngMQ1mA nHyLeMEJNZamlYwRyOJWZ1duJwn4n6fdAgBZyF4iRjuijHMDehcVRRqldb1mJxuU7O L6uLiOaruevwG4XaPRaBwQkpW/hhbzlmUknu6qR5YwTTfYEIzVeZx6YqONRh+nbq6E rG9b6fL40TK3g== Received: by mail-lf1-f49.google.com with SMTP id q8so2432512lfm.10 for ; Wed, 20 Jan 2021 05:14:39 -0800 (PST) X-Gm-Message-State: AOAM530siJ9olIlK5GKcRXPvLTBSrpcie6mpLF7q0/bG326aQPi+fSDQ sa3Ld93ecUbNzZePfJH2soukW/SDBX5SjBgXOhvXVA== X-Google-Smtp-Source: ABdhPJwawW11X5iYWnsm7L16MlX0ajtl8yyrregStk3UhMSaOYlPVR4hFbvlBPmgF/Zt7P4AaTVWXn8y9EekG/OQR6g= X-Received: by 2002:a19:4941:: with SMTP id l1mr4149690lfj.80.1611148477497; Wed, 20 Jan 2021 05:14:37 -0800 (PST) MIME-Version: 1.0 References: <20210119155953.803818-1-revest@chromium.org> In-Reply-To: <20210119155953.803818-1-revest@chromium.org> From: KP Singh Date: Wed, 20 Jan 2021 14:14:26 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v5 1/4] bpf: Be less specific about socket cookies guarantees To: Florent Revest Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Florent Revest , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2021 at 5:00 PM Florent Revest wrote: > > Since "92acdc58ab11 bpf, net: Rework cookie generator as per-cpu one" > socket cookies are not guaranteed to be non-decreasing. The > bpf_get_socket_cookie helper descriptions are currently specifying that > cookies are non-decreasing but we don't want users to rely on that. > > Reported-by: Daniel Borkmann > Signed-off-by: Florent Revest Acked-by: KP Singh