From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D5D4C4320A for ; Tue, 24 Aug 2021 09:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64A8161262 for ; Tue, 24 Aug 2021 09:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230159AbhHXJOS (ORCPT ); Tue, 24 Aug 2021 05:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232653AbhHXJOQ (ORCPT ); Tue, 24 Aug 2021 05:14:16 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C55B0C061760 for ; Tue, 24 Aug 2021 02:13:32 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id z5so39676315ybj.2 for ; Tue, 24 Aug 2021 02:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zgWUg1cu9y2wNzJh4uBLrobUt8MwmGlK5zzyl+Ymn0k=; b=wAelqMeRa21jd5nmjMo9hwwxRDvt9UIKOVhDEHom+7maZ+SffpJq5CeH6nUFpLZNOp rXiAdIDqk1HheALul4vl1yCtv8GDdP8mLei0xNnpHDirbnjQNSjst+sDuom3GjLsESmW jREI3xKkAFzwf6cGiwCpSQbwUblllNBmAyN7P1CAS/N272Wxc2izTwqIpbypculHmgkG WeW6BYFN0h7fjN9mL4MPA4FvpeTDhHcLK3BmpWSBycxok15ideqDZ7TXCq1gNuNZqME4 yXKO/f+XxLRbqMRyQssgmph7lPjC7ndOPUgvFy60lmuRoMAIAfbq7cGdVUTMLDfuPE1m 7U9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zgWUg1cu9y2wNzJh4uBLrobUt8MwmGlK5zzyl+Ymn0k=; b=bO5j1Mn6hJvOvlvJrWB75rCsDNqnZCUk+7Enk7zfJ7jnabbsxtbHYyTxxvft/cE+Mw TCSi+pfHk+f7gVWSvTD/ximuRDHwLa+bK8s+TK14GmfvYuEPzhghAyZgLA1f5I58QuBt IA6J6Kctfq4Pamd7Zp07Qp12rLhx7qwPR4beTCEQHSOYiOW/khDqVZUMvwTSXa1eNTso ktLXx3qgKfxo8WnW+6EhCWTOOTXJ+vTLlgEFXSo9eZ/3iq4rzAf/xDB7XABq8o5DxxzM 0YeP6Ii7UNVu+m7dUzvwAVeHGmj7MVYn9iEVORwZxOYON9N2Jcm1KP959cMcs9EYz4bg U+0A== X-Gm-Message-State: AOAM533bJwD6gMf9/apj8h4Ubd9U6jACegAJNNVa/URZLN1kVWB41IwG PdkGgt2ZJ8Yu3ePUtqFkWNpfjdWipGjtsDgaJxlY+g== X-Google-Smtp-Source: ABdhPJyJfp5NzkWtY0l7A9iMamwp9I5qxRl6XzHvf63lLqGTmx6J7/yPKuYx9ul+6aoB5WvwkM2uNDRTIwzn+uuWMyM= X-Received: by 2002:a25:3545:: with SMTP id c66mr49877960yba.317.1629796412021; Tue, 24 Aug 2021 02:13:32 -0700 (PDT) MIME-Version: 1.0 References: <1629796009-11010-1-git-send-email-linyunsheng@huawei.com> In-Reply-To: <1629796009-11010-1-git-send-email-linyunsheng@huawei.com> From: Ilias Apalodimas Date: Tue, 24 Aug 2021 12:12:53 +0300 Message-ID: Subject: Re: [PATCH net-next v3] page_pool: use relaxed atomic for release side accounting To: Yunsheng Lin Cc: "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Networking , open list , Heiner Kallweit Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Aug 2021 at 12:07, Yunsheng Lin wrote: > > There is no need to synchronize the account updating, so > use the relaxed atomic to avoid some memory barrier in the > data path. > > Acked-by: Jesper Dangaard Brouer > Signed-off-by: Yunsheng Lin > --- > V3: Drop patch 2. > V2: Remove unnecessary unliky() mark as pointed out by > Heiner. > --- > net/core/page_pool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index e140905..1a69784 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -370,7 +370,7 @@ void page_pool_release_page(struct page_pool *pool, struct page *page) > /* This may be the last page returned, releasing the pool, so > * it is not safe to reference pool afterwards. > */ > - count = atomic_inc_return(&pool->pages_state_release_cnt); > + count = atomic_inc_return_relaxed(&pool->pages_state_release_cnt); > trace_page_pool_state_release(pool, page, count); > } > EXPORT_SYMBOL(page_pool_release_page); > -- > 2.7.4 > Acked-by: Ilias Apalodimas