From: Nilay Vaish <nilayvaish@gmail.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, Linux Kernel list <linux-kernel@vger.kernel.org>,
pi3orama@163.com, He Kuang <hekuang@huawei.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Zefan Li <lizefan@huawei.com>
Subject: Re: [PATCH v10 07/10] perf record: Read from overwritable ring buffer
Date: Thu, 23 Jun 2016 09:27:32 -0500 [thread overview]
Message-ID: <CACbG30-YC1AN43mtkZbuyAq0YiE9YBknbhXRrYO7TYn3SoQFPw@mail.gmail.com> (raw)
In-Reply-To: <1466659667-99144-8-git-send-email-wangnan0@huawei.com>
On 23 June 2016 at 00:27, Wang Nan <wangnan0@huawei.com> wrote:
> @@ -542,6 +568,79 @@ static struct perf_event_header finished_round_event = {
> .type = PERF_RECORD_FINISHED_ROUND,
> };
>
> +static void
> +record__toggle_overwrite_evsels(struct record *rec,
> + enum overwrite_evt_state state)
> +{
> + struct perf_evlist *evlist = rec->overwrite_evlist;
> + enum overwrite_evt_state old_state = rec->overwrite_evt_state;
> + enum action {
> + NONE,
> + PAUSE,
> + RESUME,
> + } action = NONE;
> +
> + switch (old_state) {
> + case OVERWRITE_EVT_RUNNING: {
> + switch (state) {
> + case OVERWRITE_EVT_DATA_PENDING:
> + action = PAUSE;
> + break;
> + case OVERWRITE_EVT_RUNNING:
> + case OVERWRITE_EVT_EMPTY:
> + default:
> + goto state_err;
> + }
> + break;
> + }
> + case OVERWRITE_EVT_DATA_PENDING: {
> + switch (state) {
> + case OVERWRITE_EVT_EMPTY:
> + break;
> + case OVERWRITE_EVT_RUNNING:
> + case OVERWRITE_EVT_DATA_PENDING:
> + default:
> + goto state_err;
> + }
> + break;
> + }
> + case OVERWRITE_EVT_EMPTY: {
> + switch (state) {
> + case OVERWRITE_EVT_RUNNING:
> + action = RESUME;
> + break;
> + case OVERWRITE_EVT_EMPTY:
> + case OVERWRITE_EVT_DATA_PENDING:
> + default:
> + goto state_err;
Wang, thanks for making the changes I suggested.
The patch overall looks fine to me. Just as a matter
of style, I probably would not write case labels that
do not have any statements associated with them.
I'll let default take care of those labels.
--
Nilay
next prev parent reply other threads:[~2016-06-23 14:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 5:27 [PATCH v10 00/10] perf tools: Support overwritable ring buffer Wang Nan
2016-06-23 5:27 ` [PATCH v10 01/10] perf record: Prepare mmap multiple evlists Wang Nan
2016-06-23 5:27 ` [PATCH v10 02/10] perf record: Prepare reading from multiple evlists in record__mmap_read_all() Wang Nan
2016-06-23 5:27 ` [PATCH v10 03/10] perf record: Prepare picking perf_event_mmap_page from multiple evlists Wang Nan
2016-06-23 5:27 ` [PATCH v10 04/10] perf evlist: Introduce aux evlist Wang Nan
2016-06-23 14:15 ` Nilay Vaish
2016-06-23 5:27 ` [PATCH v10 05/10] perf tests: Add testcase for auxiliary evlist Wang Nan
2016-06-23 5:27 ` [PATCH v10 06/10] perf record: Introduce rec->overwrite_evlist for overwritable events Wang Nan
2016-06-23 5:27 ` [PATCH v10 07/10] perf record: Read from overwritable ring buffer Wang Nan
2016-06-23 14:27 ` Nilay Vaish [this message]
2016-06-23 14:31 ` pi3orama
2016-06-23 17:38 ` Nilay Vaish
2016-06-23 5:27 ` [PATCH v10 08/10] perf tools: Enable overwrite settings Wang Nan
2016-06-23 5:27 ` [PATCH v10 09/10] perf tools: Don't warn about out of order event if write_backward is used Wang Nan
2016-06-23 5:27 ` [PATCH v10 10/10] perf tools: Add --tail-synthesize option Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACbG30-YC1AN43mtkZbuyAq0YiE9YBknbhXRrYO7TYn3SoQFPw@mail.gmail.com \
--to=nilayvaish@gmail.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).