From: Nilay Vaish <nilayvaish@gmail.com>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Vegard Nossum <vegard.nossum@gmail.com>,
Paul Turner <pjt@google.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 3/4] perf/core: introduce PMU_EV_CAP_READ_ACTIVE_PKG
Date: Wed, 10 Aug 2016 13:27:34 -0500 [thread overview]
Message-ID: <CACbG30-i+GrocfhJMRO+2KKbU7394W_RZELaLPst-m6BbBvohw@mail.gmail.com> (raw)
In-Reply-To: <1470781684-41663-1-git-send-email-davidcc@google.com>
On 9 August 2016 at 17:28, David Carrillo-Cisneros <davidcc@google.com> wrote:
> Introduce the flag PMU_EV_CAP_READ_ACTIVE_PKG, useful for uncore events,
> that allows a PMU to signal the generic perf code that an event is readable
> in the current CPU if the event is active in a CPU in the same package as
> the current CPU.
>
> This is an optimization that avoids a unnecessary IPI for the common case
> where uncore events are run and read in the same package but in
> different CPUs.
>
> As an example, the IPI removal speeds up perf_read in my Haswell system
> as follows:
> - For event UNC_C_LLC_LOOKUP: From 260 us to 31 us.
> - For event RAPL's power/energy-cores/: From to 255 us to 27 us.
>
> For the optimization to work, all events in the group must have it
> (similarly to PERF_EV_CAP_SOFTWARE).
>
> Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
> ---
> include/linux/perf_event.h | 3 +++
> kernel/events/core.c | 26 ++++++++++++++++++++++++--
> 2 files changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index fa5617f..c8bb1b3 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -501,8 +501,11 @@ typedef void (*perf_overflow_handler_t)(struct perf_event *,
> * Event capabilities. For event_caps and groups caps.
> *
> * PERF_EV_CAP_SOFTWARE: Is a software event.
> + * PERF_EV_CAP_READ_ACTIVE_PKG: A CPU event (or cgroup event) that can be read
> + * from any CPU in the package where it is active.
> */
> #define PERF_EV_CAP_SOFTWARE BIT(0)
> +#define PERF_EV_CAP_READ_ACTIVE_PKG BIT(1)
>
> #define SWEVENT_HLIST_BITS 8
> #define SWEVENT_HLIST_SIZE (1 << SWEVENT_HLIST_BITS)
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 34049cc..38ec68d 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -3333,6 +3333,22 @@ struct perf_read_data {
> int ret;
> };
>
> +static int find_cpu_to_read(struct perf_event *event, int local_cpu)
> +{
> + int event_cpu = event->oncpu;
> + u16 local_pkg, event_pkg;
> +
> + if (event->group_caps & PERF_EV_CAP_READ_ACTIVE_PKG) {
> + event_pkg = topology_physical_package_id(event_cpu);
> + local_pkg = topology_physical_package_id(local_cpu);
> +
> + if (event_pkg == local_pkg)
> + return local_cpu;
> + }
> +
> + return event_cpu;
> +}
> +
> /*
> * Cross CPU call to read the hardware event
> */
> @@ -3454,7 +3470,7 @@ u64 perf_event_read_local(struct perf_event *event)
>
> static int perf_event_read(struct perf_event *event, bool group)
> {
> - int ret = 0;
> + int ret = 0, cpu_to_read, local_cpu;
>
> /*
> * If event is enabled and currently active on a CPU, update the
> @@ -3466,8 +3482,14 @@ static int perf_event_read(struct perf_event *event, bool group)
> .group = group,
> .ret = 0,
> };
> - ret = smp_call_function_single(event->oncpu,
> +
> + local_cpu = get_cpu();
> + cpu_to_read = find_cpu_to_read(event, local_cpu);
> + put_cpu();
> +
> + ret = smp_call_function_single(cpu_to_read,
> __perf_event_read, &data, 1);
> +
> ret = ret ? : data.ret;
> } else if (event->state == PERF_EVENT_STATE_INACTIVE) {
> struct perf_event_context *ctx = event->ctx;
> --
> 2.8.0.rc3.226.g39d4020
>
David, thanks for making the changes. This patch looks good to me.
--
Nilay
next prev parent reply other threads:[~2016-08-10 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 3:12 [PATCH v2 0/4] remove unnecessary IPI reading uncore events David Carrillo-Cisneros
2016-08-07 3:12 ` [PATCH v2 1/4] perf/core: check return value of perf_event_read IPI David Carrillo-Cisneros
2016-08-10 11:04 ` Ingo Molnar
2016-08-17 20:53 ` David Carrillo-Cisneros
2016-08-07 3:12 ` [PATCH v2 2/4] perf/core: generalize event->group_flags David Carrillo-Cisneros
2016-08-07 3:12 ` [PATCH v2 3/4] perf/core: introduce PMU_EV_CAP_READ_ACTIVE_PKG David Carrillo-Cisneros
2016-08-07 19:10 ` Nilay Vaish
2016-08-07 20:10 ` David Carrillo-Cisneros
2016-08-08 16:12 ` Nilay Vaish
2016-08-09 5:04 ` David Carrillo-Cisneros
2016-08-09 22:28 ` [PATCH " David Carrillo-Cisneros
2016-08-10 18:27 ` Nilay Vaish [this message]
2016-08-08 10:00 ` [PATCH v3 " David Carrillo-Cisneros
2016-08-07 3:12 ` [PATCH v2 4/4] perf/x86: use PMUEF_READ_CPU_PKG in uncore events David Carrillo-Cisneros
2016-08-10 18:30 ` [PATCH v2 0/4] remove unnecessary IPI reading " Nilay Vaish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACbG30-i+GrocfhJMRO+2KKbU7394W_RZELaLPst-m6BbBvohw@mail.gmail.com \
--to=nilayvaish@gmail.com \
--cc=ak@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=vegard.nossum@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).