From: Nilay Vaish <nilayvaish@gmail.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, Linux Kernel list <linux-kernel@vger.kernel.org>,
pi3orama@163.com, He Kuang <hekuang@huawei.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Zefan Li <lizefan@huawei.com>
Subject: Re: [PATCH v9 5/8] perf record: Toggle overwrite ring buffer for reading
Date: Wed, 22 Jun 2016 09:33:05 -0500 [thread overview]
Message-ID: <CACbG30-ymdXDoMKSGvFDGBvnF5chHrbGOHXy5bxRM0L+uOrR9w@mail.gmail.com> (raw)
In-Reply-To: <1466586531-89751-6-git-send-email-wangnan0@huawei.com>
On 22 June 2016 at 04:08, Wang Nan <wangnan0@huawei.com> wrote:
> @@ -549,17 +573,72 @@ static struct perf_event_header finished_round_event = {
> .type = PERF_RECORD_FINISHED_ROUND,
> };
>
> -static int record__mmap_read_all(struct record *rec)
> +static void
> +record__toggle_overwrite_evsels(struct record *rec,
> + enum overwrite_evt_state state)
> +{
> + struct perf_evlist *evlist = rec->overwrite_evlist;
> + enum overwrite_evt_state old_state = rec->overwrite_evt_state;
> + enum action {
> + NONE,
> + PAUSE,
> + RESUME,
> + } action = NONE;
> +
> + switch (old_state) {
> + case OVERWRITE_EVT_RUNNING:
> + if (state != OVERWRITE_EVT_RUNNING)
> + action = PAUSE;
> + break;
> + case OVERWRITE_EVT_DATA_PENDING:
> + if (state == OVERWRITE_EVT_RUNNING)
> + action = RESUME;
> + break;
> + case OVERWRITE_EVT_EMPTY:
> + if (state == OVERWRITE_EVT_RUNNING)
> + action = RESUME;
> + if (state == OVERWRITE_EVT_DATA_PENDING)
> + state = OVERWRITE_EVT_EMPTY;
else if (state == OVERWRITE_EVT_DATA_PENDING)
> + break;
> + default:
> + WARN_ONCE(1, "Shouldn't get there\n");
> + }
> +
> + rec->overwrite_evt_state = state;
> +
> + if (action == NONE)
> + return;
I think the above two lines are not required. The switch below should
be enough.
> +
> + if (!evlist)
> + return;
> +
> + switch (action) {
> + case PAUSE:
> + perf_evlist__pause(evlist);
> + break;
> + case RESUME:
> + perf_evlist__resume(evlist);
> + break;
> + case NONE:
> + default:
> + break;
> + }
> +}
> +
--
Nilay
next prev parent reply other threads:[~2016-06-22 14:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 9:08 [PATCH v9 0/8] perf tools: Support overwritable ring buffer Wang Nan
2016-06-22 9:08 ` [PATCH v9 1/8] perf evlist: Introduce aux evlist Wang Nan
2016-06-22 13:17 ` Nilay Vaish
2016-06-22 13:40 ` Arnaldo Carvalho de Melo
2016-06-23 1:29 ` Wangnan (F)
2016-06-23 2:11 ` [PATCH v9.1] " Wang Nan
2016-06-22 9:08 ` [PATCH v9 2/8] perf tests: Add testcase for auxiliary evlist Wang Nan
2016-06-22 9:08 ` [PATCH v9 3/8] perf record: Extract perf_evlist__mmap_ex() processing to a new function Wang Nan
2016-06-22 9:08 ` [PATCH v9 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events Wang Nan
2016-06-22 9:08 ` [PATCH v9 5/8] perf record: Toggle overwrite ring buffer for reading Wang Nan
2016-06-22 14:33 ` Nilay Vaish [this message]
2016-06-23 1:19 ` Wangnan (F)
2016-06-22 9:08 ` [PATCH v9 6/8] perf tools: Enable overwrite settings Wang Nan
2016-06-22 9:08 ` [PATCH v9 7/8] perf tools: Don't warn about out of order event if write_backward is used Wang Nan
2016-06-22 9:08 ` [PATCH v9 8/8] perf tools: Add --tail-synthesize option Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACbG30-ymdXDoMKSGvFDGBvnF5chHrbGOHXy5bxRM0L+uOrR9w@mail.gmail.com \
--to=nilayvaish@gmail.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).