archive mirror
 help / color / mirror / Atom feed
From: Matthew Garrett <>
To: Dave Young <>
Cc: linux-efi <>,
	Ard Biesheuvel <>,,
	Linux Kernel Mailing List <>,
Subject: Re: [PATCH] do not clean dummy variable in kexec path
Date: Mon, 5 Aug 2019 10:09:43 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Aug 5, 2019 at 1:36 AM Dave Young <> wrote:
> kexec reboot fails randomly in UEFI based kvm guest.  The firmware
> just reset while calling efi_delete_dummy_variable();  Unfortunately
> I don't know how to debug the firmware, it is also possible a potential
> problem on real hardware as well although nobody reproduced it.
> The intention of efi_delete_dummy_variable is to trigger garbage collection
> when entering virtual mode.  But SetVirtualAddressMap can only run once
> for each physical reboot, thus kexec_enter_virtual_mode is not necessarily
> a good place to clean dummy object.

I agree that this isn't necessarily the best place to do this in the
kexec case, but given we control the firmware, figuring out what's
actually breaking seems like a good plan.

  parent reply	other threads:[~2019-08-05 17:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-05  8:35 Dave Young
2019-08-05 15:55 ` Ard Biesheuvel
2019-08-06  2:41   ` Dave Young
2019-08-08  7:49   ` Dave Young
2019-08-05 17:09 ` Matthew Garrett [this message]
2019-08-06  2:44   ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] do not clean dummy variable in kexec path' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).