From: Prashant Malani <pmalani@chromium.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
"open list:CHROMEOS EC USB TYPE-C DRIVER"
<chrome-platform@lists.linux.dev>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux
Date: Mon, 7 Feb 2022 22:04:27 -0800 [thread overview]
Message-ID: <CACeCKacQP4OjfQ-x8VE66bnh1J28jsYjC3udjiHZN7hJrmDGsw@mail.gmail.com> (raw)
In-Reply-To: <YgIBIlnLPiV+49HI@google.com>
On Mon, Feb 7, 2022 at 9:35 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
>
> On Mon, Feb 07, 2022 at 09:40:26PM +0000, Prashant Malani wrote:
> > Move the function which gets current mux state inside the
> > cros_typec_configure_mux() function. It is better to group those
> > bits of functionality together, and it makes it easier to move around
> > cros_typec_configure_mux() later.
>
> nit: s/Move/Moves/.
Move is fine. Please see:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-your-changes
Quoting from the above: " Describe your changes in imperative mood,"
>
> > static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> > - uint8_t mux_flags,
> > struct ec_response_usb_pd_control_v2 *pd_ctrl)
> > {
> > struct cros_typec_port *port = typec->ports[port_num];
> > + struct ec_response_usb_pd_mux_info mux_resp;
> > + struct ec_params_usb_pd_mux_info req = {
> > + .port = port_num,
> > + };
> > struct ec_params_usb_pd_mux_ack mux_ack;
> > enum typec_orientation orientation;
> > int ret = 0;
> >
> > + ret = cros_ec_command(typec->ec, 0, EC_CMD_USB_PD_MUX_INFO,
> > + &req, sizeof(req), &mux_resp, sizeof(mux_resp));
>
> It was `req` and `resp` in cros_typec_get_mux_info(). However, `mux_resp` for
> separating from `struct ec_response_usb_pd_control_v2 resp` in
> cros_typec_port_update().
>
> It would be neat to be either {`req`, `resp`} or {`mux_req`, `mux_resp`} in
> cros_typec_configure_mux().
I'll change it to resp (instead of mux_resp)
next prev parent reply other threads:[~2022-02-08 6:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 21:40 [PATCH 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
2022-02-07 21:40 ` [PATCH 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Prashant Malani
2022-02-08 5:33 ` Tzung-Bi Shih
2022-02-08 6:03 ` Prashant Malani
2022-02-07 21:40 ` [PATCH 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux Prashant Malani
2022-02-08 5:35 ` Tzung-Bi Shih
2022-02-08 6:04 ` Prashant Malani [this message]
2022-02-07 21:40 ` [PATCH 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update Prashant Malani
2022-02-08 5:38 ` Tzung-Bi Shih
2022-02-08 6:12 ` Prashant Malani
2022-02-08 11:15 ` Tzung-Bi Shih
2022-02-08 18:35 ` Prashant Malani
2022-02-08 22:58 ` Prashant Malani
2022-02-09 3:31 ` Tzung-Bi Shih
2022-02-09 3:41 ` Prashant Malani
2022-02-07 21:40 ` [PATCH 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal Prashant Malani
2022-02-08 5:38 ` Tzung-Bi Shih
2022-02-08 6:15 ` Prashant Malani
2022-02-08 11:15 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACeCKacQP4OjfQ-x8VE66bnh1J28jsYjC3udjiHZN7hJrmDGsw@mail.gmail.com \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).