From: Prashant Malani <pmalani@chromium.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
bleung@chromium.org, swboyd@chromium.org,
heikki.krogerus@linux.intel.com,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"José Expósito" <jose.exposito89@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Maxime Ripard" <maxime@cerno.tech>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Pin-Yen Lin" <treapking@chromium.org>,
"Robert Foss" <robert.foss@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Tzung-Bi Shih" <tzungbi@google.com>,
"Xin Ji" <xji@analogixsemi.com>
Subject: Re: [PATCH v2 5/7] drm/bridge: anx7625: Register number of Type C switches
Date: Mon, 13 Jun 2022 13:48:13 -0700 [thread overview]
Message-ID: <CACeCKacaq_6zc9daL38VycCxWaNvVHFETBfytrDXTBCa3Y3jRw@mail.gmail.com> (raw)
In-Reply-To: <20220613204544.onfazkv4ciphddm3@notapiano>
Hi Nícolas,
On Mon, Jun 13, 2022 at 1:45 PM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> Hi Prashant,
>
> On Thu, Jun 09, 2022 at 06:09:44PM +0000, Prashant Malani wrote:
> > Parse the "switches" node, if available, and count and store the number
> > of Type-C switches within it. Since we currently don't do anything with
> > this info, no functional changes are expected from this change.
> >
> > This patch sets a foundation for the actual registering of Type-C
> > switches with the Type-C connector class framework.
> >
> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
> > ---
> >
> > Changes since v1:
> > - No changes.
> >
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 20 ++++++++++++++++++++
> > drivers/gpu/drm/bridge/analogix/anx7625.h | 1 +
> > 2 files changed, 21 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 53a5da6c49dd..07ed44c6b839 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -2581,6 +2581,22 @@ static void anx7625_runtime_disable(void *data)
> > pm_runtime_disable(data);
> > }
> >
> > +static int anx7625_register_typec_switches(struct device *device, struct anx7625_data *ctx)
> > +{
> > + struct device_node *of = NULL;
> > + int ret = 0;
> > +
> > + of = of_get_child_by_name(device->of_node, "switches");
> > + if (!of)
> > + return -ENODEV;
> > +
> > + ctx->num_typec_switches = of_get_child_count(of);
> > + if (ctx->num_typec_switches <= 0)
> > + return -ENODEV;
>
> Since the hardware only allows at most 2 switches (based on the dt-bindings),
> you should have a define for that limit and check that it isn't exceeded here.
This is already enforced by the DT binding (see the
"patternProperties" in patch 4/7, suggested by Krzysztof in the
previous version)
>
> Thanks,
> Nícolas
>
> > +
> > + return ret;
> > +}
> > +
> > static int anx7625_i2c_probe(struct i2c_client *client,
> > const struct i2c_device_id *id)
> > {
> > @@ -2686,6 +2702,10 @@ static int anx7625_i2c_probe(struct i2c_client *client,
> > if (platform->pdata.intp_irq)
> > queue_work(platform->workqueue, &platform->work);
> >
> > + ret = anx7625_register_typec_switches(dev, platform);
> > + if (ret)
> > + dev_info(dev, "Didn't register Type C switches, err: %d\n", ret);
> > +
> > platform->bridge.funcs = &anx7625_bridge_funcs;
> > platform->bridge.of_node = client->dev.of_node;
> > if (!anx7625_of_panel_on_aux_bus(&client->dev))
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h
> > index e257a84db962..d5cbca708842 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.h
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.h
> > @@ -473,6 +473,7 @@ struct anx7625_data {
> > struct drm_connector *connector;
> > struct mipi_dsi_device *dsi;
> > struct drm_dp_aux aux;
> > + int num_typec_switches;
> > };
> >
> > #endif /* __ANX7625_H__ */
> > --
> > 2.36.1.476.g0c4daa206d-goog
> >
next prev parent reply other threads:[~2022-06-13 21:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 18:09 [PATCH v2 0/7] usb: typec: Introduce typec-switch binding Prashant Malani
2022-06-09 18:09 ` [PATCH v2 1/7] usb: typec: mux: Allow muxes to specify mode-switch Prashant Malani
2022-06-14 7:42 ` Heikki Krogerus
2022-06-14 8:27 ` AngeloGioacchino Del Regno
2022-06-09 18:09 ` [PATCH v2 2/7] usb: typec: mux: Add CONFIG guards for functions Prashant Malani
2022-06-14 8:10 ` Heikki Krogerus
2022-06-14 8:27 ` AngeloGioacchino Del Regno
2022-06-09 18:09 ` [PATCH v2 3/7] dt-bindings: usb: Add Type-C switch binding Prashant Malani
2022-06-13 20:38 ` Nícolas F. R. A. Prado
2022-06-13 20:44 ` Prashant Malani
2022-06-09 18:09 ` [PATCH v2 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Prashant Malani
2022-06-09 18:09 ` [PATCH v2 5/7] drm/bridge: anx7625: Register number of Type C switches Prashant Malani
2022-06-13 20:45 ` Nícolas F. R. A. Prado
2022-06-13 20:48 ` Prashant Malani [this message]
2022-06-14 8:22 ` AngeloGioacchino Del Regno
2022-06-14 18:13 ` Prashant Malani
2022-06-09 18:09 ` [PATCH v2 6/7] drm/bridge: anx7625: Register Type-C mode switches Prashant Malani
2022-06-14 8:18 ` AngeloGioacchino Del Regno
2022-06-14 16:57 ` Prashant Malani
2022-06-15 8:45 ` AngeloGioacchino Del Regno
2022-06-15 17:00 ` Prashant Malani
2022-06-09 18:09 ` [PATCH v2 7/7] drm/bridge: anx7625: Add typec_mux_set callback function Prashant Malani
2022-06-13 20:51 ` Nícolas F. R. A. Prado
2022-06-13 21:31 ` Prashant Malani
2022-06-14 8:15 ` AngeloGioacchino Del Regno
2022-06-14 9:08 ` Pin-yen Lin
2022-06-14 16:58 ` Prashant Malani
2022-06-15 13:57 ` AngeloGioacchino Del Regno
2022-06-13 20:58 ` [PATCH v2 0/7] usb: typec: Introduce typec-switch binding Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACeCKacaq_6zc9daL38VycCxWaNvVHFETBfytrDXTBCa3Y3jRw@mail.gmail.com \
--to=pmalani@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jose.exposito89@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
--cc=tzimmermann@suse.de \
--cc=tzungbi@google.com \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).