From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4CA7C433DB for ; Fri, 5 Feb 2021 20:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52D3764FBA for ; Fri, 5 Feb 2021 20:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233444AbhBESZZ (ORCPT ); Fri, 5 Feb 2021 13:25:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233472AbhBESYG (ORCPT ); Fri, 5 Feb 2021 13:24:06 -0500 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D738C061788 for ; Fri, 5 Feb 2021 12:05:50 -0800 (PST) Received: by mail-qv1-xf32.google.com with SMTP id j4so4072027qvk.6 for ; Fri, 05 Feb 2021 12:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=COIVkmLKVjBxWkNd3sXcovxZhEaGvx0vE0V8HNc6fkw=; b=MMKKfiqqZSmiiR7dwaMA2hEB2+eyZZcoiYb3co6cQsig958i/s3kiTTfJiJPvrubBJ dL2+N+3u2ZNmix9XN59xN8Csy7IB19VuE7dsvIPZxS9ukugAjRDvjyCD+fdo8E1GawAh Hkw/+vpjf7E8vxb00zu2JEB/BUmtEo+ydwXek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=COIVkmLKVjBxWkNd3sXcovxZhEaGvx0vE0V8HNc6fkw=; b=tOnDuDNTT2oXu76csxCX1j7XUHbdNujsJapMBRHmSofMIFN1ALs/khqi9GZ3Jyhbiz rPhAO7Nui3Wk1ZUyM88yeR1lM2iQIMGwU9+dfY3mPkj9KmOvu46X67TauE3l1P5aBK0t BlUegnMLdDg7lvZuFDY25C9ZVKvBL8irUI6hrzHnLR57GRF5IPLkkHMilsWHbkg3v6vl 4Ssqwp/0UQz8jEeD5x85C4DivSUFkd+j7P00PICxooO/f3VPItO5xDlfvL95G8z+fTGa mBZMEslDsTeY3W/sWfsFrzitk+13AAmihQaElh14SugVRaKSXknwQj7Lg+aHuN+I5XIU 6xyQ== X-Gm-Message-State: AOAM5317ERjBaJzcjEylPgYpYj1RNVcAOpXD00oVMqEIN1ckz6aYH/Zt m0IrMXiup4IuclgwbGk7Pek+8ZP/lW5ZOOZUOplerg== X-Google-Smtp-Source: ABdhPJw9P4aHZiurZFpu2ywUm+vHxcCvBFwQC5Uv94xO+vrAOs73MGnhBXE4PYG6PuvNBCPFmecYPswJ0c8cTH96/UI= X-Received: by 2002:a05:6214:18f0:: with SMTP id ep16mr5984767qvb.0.1612555549642; Fri, 05 Feb 2021 12:05:49 -0800 (PST) MIME-Version: 1.0 References: <20210205195113.20277-1-rajmohan.mani@intel.com> <20210205195113.20277-3-rajmohan.mani@intel.com> In-Reply-To: <20210205195113.20277-3-rajmohan.mani@intel.com> From: Prashant Malani Date: Fri, 5 Feb 2021 12:05:38 -0800 Message-ID: Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_types: Support disconnect events without partners To: Rajmohan Mani Cc: Benson Leung , Enric Balletbo i Serra , Guenter Roeck , Linux Kernel Mailing List , Heikki Krogerus Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Raj, On Fri, Feb 5, 2021 at 11:52 AM Rajmohan Mani wrote: > > There are certain scenarios, where a disconnect event might > occur on a Type-C port with no port partners. This is required > to enable communication to Burnside Bridge USB4 retimers. > > Signed-off-by: Rajmohan Mani minor commit message nit (apologies for not spotting this earlier): This patch alone doesn't add support for the "without partners" part (that comes in the next patch). This one purely adds support for disconnect events. So might be good to update the commit message if possible. But otherwise LGTM, so: Reviewed-by: Prashant Malani