From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7620C2D0DB for ; Thu, 30 Jan 2020 20:38:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9EA2420674 for ; Thu, 30 Jan 2020 20:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="T2JbwFOc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727591AbgA3Uim (ORCPT ); Thu, 30 Jan 2020 15:38:42 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:37858 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727089AbgA3Uim (ORCPT ); Thu, 30 Jan 2020 15:38:42 -0500 Received: by mail-qk1-f196.google.com with SMTP id 21so4356522qky.4 for ; Thu, 30 Jan 2020 12:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lXLcZPObxCg8UpW3wsyFd8cvt+7c4lagGHfRBNizr6Y=; b=T2JbwFOcji3ikSYb44ioObVaHmwPGgpGajFJoUUcaGhlbK9fVjmMHX6qB3d8CUrqVg aehh0+OxWUFsgRZSSVBlSRyhIpLiAhbB1a1OyZxe+6/ZuoSHcMblV9vINIE25XntUKxt IkYpdYFM7yWc2K8HbzERXb8QoNFCn++PQAcSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lXLcZPObxCg8UpW3wsyFd8cvt+7c4lagGHfRBNizr6Y=; b=iK8u6B41Mdrzy3iqy5dO5GUYuyt2/pyaaxm7cGD2aokQClS+N523dlBuYcJM8c0wUs Sx9rZiJ+w8hQMB9ai5GOKGJCNrs0bs5BMS5rvn61gYUPWZ691zDKaC4RzShuS9WMyZZW +1dl39OQKXm44WJUnAsE5KA8Xdjv0LPLarPz5T8yraz/i5vKap7HUqT8+6EhR1TmRSOK i3Qcq5QmNMKI42v7L71LdjPZ3nV0GCwGFLshymQq8bs5Uz4BlQewQtNP7x61/PLIY/7J BPi++KhjRnN/qkKg4NllJxnRFo4rmVdN5IM7HnRFtcqXwho7kYIIgvz0xDqwqmlQ49+5 o+IQ== X-Gm-Message-State: APjAAAUY+16T9d+ZG9+IAxJB7rfCoVpUqQwXCaFjSKDV7n1RjFBSkxN0 X4YFqv4hBxZnCrOTcDOWIfqExOM8vqkHQak2ii5jqg== X-Google-Smtp-Source: APXvYqzYiPhz1UiyzdGN6otP3NPNlkmS6XvzwAVnLMATJbQBYBb3QX+D0u5qlRT4RWXxFmd9xPI2RVOD67o0uuSmRUQ= X-Received: by 2002:ae9:e910:: with SMTP id x16mr7299451qkf.90.1580416721181; Thu, 30 Jan 2020 12:38:41 -0800 (PST) MIME-Version: 1.0 References: <20200125012105.59903-1-pmalani@chromium.org> <20200125012105.59903-2-pmalani@chromium.org> In-Reply-To: From: Prashant Malani Date: Thu, 30 Jan 2020 12:38:30 -0800 Message-ID: Subject: Re: [PATCH 1/4] platform/chrome: Add EC command msg wrapper To: Enric Balletbo Serra Cc: Enric Balletbo i Serra , Benson Leung , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, Here is the series: https://www.spinics.net/lists/kernel/msg3392039.html Thanks! On Tue, Jan 28, 2020 at 12:58 PM Prashant Malani wrote: > > > > On Tue, Jan 28, 2020 at 12:57 PM Enric Balletbo Serra wrote: >> >> Missatge de Prashant Malani del dia dt., 28 de >> gen. 2020 a les 20:29: >> > >> > Hi Enric, >> > >> > On Mon, Jan 27, 2020 at 12:36 PM Enric Balletbo Serra >> > wrote: >> > > >> > > Hi Prashant, >> > > >> > > Missatge de Prashant Malani del dia dl., 27 de >> > > gen. 2020 a les 18:13: >> > > > >> > > > Hi Enric, >> > > > >> > > > On Mon, Jan 27, 2020 at 7:29 AM Enric Balletbo i Serra >> > > > wrote: >> > > > > >> > > > > Hi Prashant, >> > > > > >> > > > > Many thanks for this patch. >> > > > > >> > > > > On 25/1/20 2:21, Prashant Malani wrote: >> > > > > > Many callers of cros_ec_cmd_xfer_status() use a similar set up of >> > > > > > allocating and filling a message buffer and then copying any received >> > > > > > data to a target buffer. >> > > > > > >> > > > > >> > > > > cros_ec_cmd_xfer_status is already a wrapper, I dislike the idea of having three >> > > > > ways to do the same (cros_ec_cmd_xfer, cros_ec_cmd_xfer_status and this new >> > > > > one). I like the idea of have a wrapper that embeds the message allocation but >> > > > > we should not confuse users with different calls that does the same. >> > > > Yes, my intention was to eventually replace all the xfer_status() >> > > > call-sites to use the new wrapper, and then get rid of xfer_status >> > > > completely. >> > > > > >> > > > > So, I am for a change like this but I'd like to have all the users calling the >> > > > > same wrapper (unless there is a good reason to not use it). A proposed roadmap >> > > > > (to be discussed) for this would be. >> > > > > >> > > > > 1. Replace all the remaining "cros_ec_cmd_xfer" calls with >> > > > > "cros_ec_cmd_xfer_status". >> > > > > 2. Modify cros_ec_cmd_xfer_status to embed the message allocation. >> > > > >> > > > How about the following alteration the the roadmap: >> > > > - Introducing the new wrapper. >> > > > - Replacing all remaining cros_ec_cmd_xfer/cros_ec_cmd_xfer_status to >> > > > use the new wrapper. >> > > > - Deleting cros_ec_cmd_xfer and cros_ec_cmd_xfer_status ? >> > > > My thinking is that this would mean fewer changes at the call-sites >> > > > compared to the original roadmap (in the original roadmap, one would >> > > > first have to modify calls to use cros_ec_cmd_xfer_status(), and then >> > > > modify them again when cros_ec_cmd_xfer_status() itself is modified to >> > > > include message allocation). >> > > > >> > > >> > > Sounds like we have a plan, looks good to me. >> > > >> > Great. Can we use the current series as a starting point for this ? >> >> I'd prefer have all the replacements in the same series. > > Thanks for the clarification. I'll work on this. > > Best, > > -Prashant >> >> >> > I've identified some of the other places which use >> > cros_ec_cmd_xfer_status() so can submit subsequent series to convert >> > those. >> > > Cheers, >> > > Enric >> > > >> > > > That said I don't have any strong preference, so either would work. >> > > > >> > > > Best regards, >> > > > > >> > > > > Thanks, >> > > > > Enric >> > > > > >> > > > > >> > > > > > Create a utility function that performs this setup so that callers can >> > > > > > use this function instead. >> > > > > > >> > > > > > Signed-off-by: Prashant Malani >> > > > > > --- >> > > > > > drivers/platform/chrome/cros_ec_proto.c | 53 +++++++++++++++++++++ >> > > > > > include/linux/platform_data/cros_ec_proto.h | 5 ++ >> > > > > > 2 files changed, 58 insertions(+) >> > > > > > >> > > > > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c >> > > > > > index da1b1c4504333..8ef3b7d27d260 100644 >> > > > > > --- a/drivers/platform/chrome/cros_ec_proto.c >> > > > > > +++ b/drivers/platform/chrome/cros_ec_proto.c >> > > > > > @@ -5,6 +5,7 @@ >> > > > > > >> > > > > > #include >> > > > > > #include >> > > > > > +#include >> > > > > > #include >> > > > > > #include >> > > > > > #include >> > > > > > @@ -570,6 +571,58 @@ int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, >> > > > > > } >> > > > > > EXPORT_SYMBOL(cros_ec_cmd_xfer_status); >> > > > > > >> > > > > > +/** >> > > > > > + * cros_ec_send_cmd_msg() - Utility function to send commands to ChromeOS EC. >> > > > > > + * @ec: EC device struct. >> > > > > > + * @version: Command version number (often 0). >> > > > > > + * @command: Command ID including offset. >> > > > > > + * @outdata: Data to be sent to the EC. >> > > > > > + * @outsize: Size of the &outdata buffer. >> > > > > > + * @indata: Data to be received from the EC. >> > > > > > + * @insize: Size of the &indata buffer. >> > > > > > + * >> > > > > > + * This function is a wrapper around &cros_ec_cmd_xfer_status, and performs >> > > > > > + * some of the common work involved with sending a command to the EC. This >> > > > > > + * includes allocating and filling up a &struct cros_ec_command message buffer, >> > > > > > + * and copying the received data to another buffer. >> > > > > > + * >> > > > > > + * Return: The number of bytes transferred on success or negative error code. >> > > > > > + */ >> > > > > > +int cros_ec_send_cmd_msg(struct cros_ec_device *ec, unsigned int version, >> > > > > > + unsigned int command, void *outdata, >> > > > > > + unsigned int outsize, void *indata, >> > > > > > + unsigned int insize) >> > > > > > +{ >> > > > > > + struct cros_ec_command *msg; >> > > > > > + int ret; >> > > > > > + >> > > > > > + msg = kzalloc(sizeof(*msg) + max(outsize, insize), GFP_KERNEL); >> > > > > > + if (!msg) >> > > > > > + return -ENOMEM; >> > > > > > + >> > > > > > + msg->version = version; >> > > > > > + msg->command = command; >> > > > > > + msg->outsize = outsize; >> > > > > > + msg->insize = insize; >> > > > > > + >> > > > > > + if (outdata && outsize > 0) >> > > > > > + memcpy(msg->data, outdata, outsize); >> > > > > > + >> > > > > > + ret = cros_ec_cmd_xfer_status(ec, msg); >> > > > > > + if (ret < 0) { >> > > > > > + dev_warn(ec->dev, "Command failed: %d\n", msg->result); >> > > > > > + goto cleanup; >> > > > > > + } >> > > > > > + >> > > > > > + if (insize) >> > > > > > + memcpy(indata, msg->data, insize); >> > > > > > + >> > > > > > +cleanup: >> > > > > > + kfree(msg); >> > > > > > + return ret; >> > > > > > +} >> > > > > > +EXPORT_SYMBOL(cros_ec_send_cmd_msg); >> > > > > > + >> > > > > > static int get_next_event_xfer(struct cros_ec_device *ec_dev, >> > > > > > struct cros_ec_command *msg, >> > > > > > struct ec_response_get_next_event_v1 *event, >> > > > > > diff --git a/include/linux/platform_data/cros_ec_proto.h b/include/linux/platform_data/cros_ec_proto.h >> > > > > > index 30098a5515231..166ce26bdd79e 100644 >> > > > > > --- a/include/linux/platform_data/cros_ec_proto.h >> > > > > > +++ b/include/linux/platform_data/cros_ec_proto.h >> > > > > > @@ -201,6 +201,11 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_dev, >> > > > > > int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, >> > > > > > struct cros_ec_command *msg); >> > > > > > >> > > > > > +int cros_ec_send_cmd_msg(struct cros_ec_device *ec_dev, unsigned int version, >> > > > > > + unsigned int command, void *outdata, >> > > > > > + unsigned int outsize, void *indata, >> > > > > > + unsigned int insize); >> > > > > > + >> > > > > > int cros_ec_register(struct cros_ec_device *ec_dev); >> > > > > > >> > > > > > int cros_ec_unregister(struct cros_ec_device *ec_dev); >> > > > > >