From: "Rafał Miłecki" <zajec5@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 2/2] reset: bcm4908-usb: add driver for BCM4908 USB reset controller
Date: Fri, 4 Dec 2020 17:29:55 +0100 [thread overview]
Message-ID: <CACna6rx16dkktfyESPNriwV1VQLYLw6sJPQjS8YQDMFey_zXzA@mail.gmail.com> (raw)
In-Reply-To: <f620c4aa8ca3ed10701c5fe050a2bed04ff759db.camel@pengutronix.de>
On Fri, 4 Dec 2020 at 17:13, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Fri, 2020-12-04 at 10:37 +0100, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > This controller is responsible for OHCI, EHCI, XHCI and PHYs setup that
> > has to be handled in the proper order.
> >
> > One unusual thing about this controller is that is provides access to
> > the MDIO bus. There are two registers (in the middle of block space)
> > responsible for that. For that reason this driver initializes regmap so
> > a proper MDIO driver can use them.
> >
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> This doesn't look like a reset controller to me, but rather like
> something that belongs in drivers/usb.
I think I found the reset API to match the best setup requirements and
assumed it should be treated as a reset controller.
Any advice, idea, how should I integrate this driver with the USB
subsystem? Rested made it easy as all I needed was:
usb@c300 {
compatible = "generic-ehci";
reg = <0xc300 0x100>;
interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
resets = <&usb_reset>;
};
--
Rafał
next prev parent reply other threads:[~2020-12-04 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 9:37 [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 USB reset binding Rafał Miłecki
2020-12-04 9:37 ` [PATCH 2/2] reset: bcm4908-usb: add driver for BCM4908 USB reset controller Rafał Miłecki
2020-12-04 16:13 ` Philipp Zabel
2020-12-04 16:29 ` Rafał Miłecki [this message]
2020-12-04 16:38 ` Florian Fainelli
2020-12-04 16:42 ` Rafał Miłecki
2020-12-04 16:32 ` [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 USB reset binding Florian Fainelli
2020-12-04 16:39 ` Rafał Miłecki
2020-12-09 23:35 ` Rob Herring
2020-12-10 0:27 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACna6rx16dkktfyESPNriwV1VQLYLw6sJPQjS8YQDMFey_zXzA@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).