From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750977AbbEAV47 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 May 2015 17:56:59 -0400
Received: from mail-ig0-f169.google.com ([209.85.213.169]:37587 "EHLO
	mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750710AbbEAV45 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 May 2015 17:56:57 -0400
MIME-Version: 1.0
In-Reply-To: <35add8df33b17e2354d9496eba8597d9d8488f30.1430430153.git.hramrach@gmail.com>
References: <cover.1430430153.git.hramrach@gmail.com>
	<35add8df33b17e2354d9496eba8597d9d8488f30.1430430153.git.hramrach@gmail.com>
Date: Fri, 1 May 2015 23:56:57 +0200
Message-ID: <CACna6rx3G+=wMyxkAjh=bT2OG1QsJvfAXSB9pE0cgYu=NhDS-g@mail.gmail.com>
Subject: Re: [PATCH 3/3] MTD: spi-nor: add flag to not use sector erase.
From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
To: Michal Suchanek <hramrach@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marex@denx.de>,
        Alison Chaiken <alison_chaiken@mentor.com>,
        Ben Hutchings <ben@decadent.org.uk>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "Bean Huo (beanhuo)" <beanhuo@micron.com>,
        "grmoore@altera.com" <grmoore@altera.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 30 April 2015 at 23:13, Michal Suchanek <hramrach@gmail.com> wrote:
> The sector size of the flash memory is unclear from datasheet or may
> possibly vary between chips so add a flag to always use 4k blocks.
>
> Currently 4k blocks are always used when possible but in the future
> somebody might want to do some optimizations with sector erase.

AFAIK most sources call 4K a sector and 64K a block. I think we should
try to stick to that (even if some current code doesn't). So it would
be nice to call 4K a sector (instead of block).