From: "Rafał Miłecki" <zajec5@gmail.com>
To: Viet Nga Dao <vndao@altera.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
nga_chi86 <ngachi86@gmail.com>
Subject: Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver
Date: Fri, 13 Mar 2015 06:45:25 +0100 [thread overview]
Message-ID: <CACna6ry5Fu2S6s761jMgsz4K-ZUEDEDJh7xd_hTfaKPGvThJjg@mail.gmail.com> (raw)
In-Reply-To: <CAN1oZWyp6bC=UhwHxKn5GPvTsr88ON9CthWWjpA8j1opgaE2-A@mail.gmail.com>
On 11 March 2015 at 09:41, Viet Nga Dao <vndao@altera.com> wrote:
> On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao <vndao@altera.com> wrote:
>> Ok. I will modify the code the way you suggest.
>
> I just realize that the opcode for RDID is handled by hardware in my
> case, therefore i dont really need to worry about 0xab opcode.
Nice :) Maybe just put a comment in code so ppl will know (in future)
why we don't strictly follow specs.
> Is there any other comments about the modified part i did the lock and
> unlock in spi-nor.c?
I can't, I don't know spi-nor well enough :|
--
Rafał
next prev parent reply other threads:[~2015-03-13 5:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 4:53 [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver Viet Nga Dao
2015-02-17 1:33 ` Viet Nga Dao
2015-02-23 1:30 ` Viet Nga Dao
2015-02-24 3:59 ` Brian Norris
2015-03-09 1:42 ` Viet Nga Dao
2015-03-13 2:42 ` Viet Nga Dao
2015-03-09 6:31 ` Rafał Miłecki
2015-03-10 6:11 ` Viet Nga Dao
2015-03-10 6:55 ` Rafał Miłecki
[not found] ` <A8F913A698B3864C898FDDF9BF921BC9E8C00F@PG-ITEXCH01.altera.priv.altera.com>
2015-03-10 8:09 ` FW: " Viet Nga Dao
2015-03-11 8:41 ` Viet Nga Dao
2015-03-13 5:45 ` Rafał Miłecki [this message]
2015-03-13 6:47 ` Viet Nga Dao
2015-03-13 7:38 ` Brian Norris
2015-03-13 8:25 ` Viet Nga Dao
2015-03-16 8:46 ` Viet Nga Dao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACna6ry5Fu2S6s761jMgsz4K-ZUEDEDJh7xd_hTfaKPGvThJjg@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ngachi86@gmail.com \
--cc=vndao@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).