From: "Rafał Miłecki" <zajec5@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Mark Rutland" <mark.rutland@arm.com>,
"Eric Anholt" <eric@anholt.net>,
"Jon Mason" <jonmason@broadcom.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5] clk: bcm: Add driver for BCM53573 ILP clock
Date: Thu, 25 Aug 2016 14:42:52 +0200 [thread overview]
Message-ID: <CACna6rzeLdAW_mEpUN355Xrr3v-zjBtQW_4z-gV1kOrPS=wr8A@mail.gmail.com> (raw)
In-Reply-To: <20160823195528.GA17844@rob-hp-laptop>
On 23 August 2016 at 21:55, Rob Herring <robh@kernel.org> wrote:
> On Tue, Aug 23, 2016 at 08:25:59AM +0200, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This clock is present on BCM53573 devices (including BCM47189) that use
>> Cortex-A7. ILP is a part of PMU (Power Management Unit) and so it should
>> be defined as one of its subnodes (subdevices). For more details see
>> Documentation entry.
>>
>> Unfortunately there isn't a set of registers related to ILP clock only.
>> We use registers 0x66c, 0x674 and 0x6dc and between them there are e.g.
>> "retention*" and "control_ext" regs. This is why this driver maps all
>> 0x1000 B of space.
>
> Then describe the block as a syscon which has several functions of
> which clocks are one.
This isn't clear to me, sorry, could you describe it? Would you like
me to update commit message or documentation? Is code fine as is?
next prev parent reply other threads:[~2016-08-25 12:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 12:05 [PATCH V3] clk: bcm: Add driver for Northstar ILP clock Rafał Miłecki
2016-08-10 17:22 ` Jon Mason
2016-08-10 17:28 ` Rafał Miłecki
2016-08-10 17:44 ` Ray Jui
2016-08-10 18:21 ` Jon Mason
2016-08-11 8:49 ` Rafał Miłecki
2016-08-11 14:25 ` Jon Mason
2016-08-12 6:26 ` Rafał Miłecki
2016-08-23 6:17 ` [PATCH V4] clk: bcm: Add driver for BCM53573 " Rafał Miłecki
2016-08-23 6:25 ` [PATCH V5] " Rafał Miłecki
2016-08-23 19:55 ` Rob Herring
2016-08-25 12:42 ` Rafał Miłecki [this message]
2016-08-31 16:16 ` Rob Herring
2016-09-05 12:12 ` Rafał Miłecki
2016-08-24 8:47 ` Stephen Boyd
2016-08-25 13:28 ` Rafał Miłecki
2016-08-25 19:57 ` Stephen Boyd
2016-08-25 14:11 ` Rafał Miłecki
2016-08-25 19:58 ` Stephen Boyd
2016-08-26 12:25 ` [PATCH V6] " Rafał Miłecki
2016-09-05 14:29 ` [PATCH V7] " Rafał Miłecki
2016-09-12 16:56 ` Rob Herring
2016-09-13 7:06 ` [PATCH V8] " Rafał Miłecki
2016-09-14 23:44 ` Rob Herring
2016-09-16 23:23 ` Stephen Boyd
2016-09-17 19:20 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACna6rzeLdAW_mEpUN355Xrr3v-zjBtQW_4z-gV1kOrPS=wr8A@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).