From: Pedro Gomes <pedrodemargomes@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon: Add option to monitor only writes
Date: Fri, 4 Feb 2022 12:11:44 -0300 [thread overview]
Message-ID: <CACpbsfZN2fExaTReJG1anDQjCd3i24_0wG-oU42dSHD5bAon7A@mail.gmail.com> (raw)
In-Reply-To: <20220203133938.1696-1-sj@kernel.org>
On Thu, Feb 3, 2022 at 10:39 AM SeongJae Park <sj@kernel.org> wrote:
> I think this would be better to be implemented as another monitoring primitive
> based on the virtual address space monitoring primitives, e.g., vaddr-writes?
> Then the implementation would be simpler and changes to other files will be
> minimized. For the user space interface, we could use a prefix to target_ids
> debugfs file. For example,
>
> # echo "vaddr-writes $(pidof workload)" > $debugfs/damon/target_ids
I will do that.
> > This patch also adds the actions mergeable and unmergeable to damos schemes.
> > These actions are used by KSM as explained in [1].
>
> Please do that in a separate patch, and also update the document
> (Documentation/admin-guide/mm/damon/usage.rst). And, what's the expected usage
> of the action and benefits?
The idea is to use this action to all areas that are not written too frequently,
this way KSM can save more memory without too much overhead.
But I have to test it better and collect some data to see if it really
makes sense,
perhaps it is better to leave this patch for later.
I would like to know your opinion on this, do you think it makes sense?
--
Atenciosamente,
Pedro Demarchi Gomes.
next prev parent reply other threads:[~2022-02-04 15:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 13:12 [PATCH] mm/damon: Add option to monitor only writes Pedro Demarchi Gomes
2022-02-03 13:39 ` SeongJae Park
2022-02-04 15:11 ` Pedro Gomes [this message]
2022-02-07 8:16 ` SeongJae Park
2022-02-04 1:29 ` kernel test robot
2022-02-04 1:29 ` kernel test robot
2022-02-04 1:30 ` kernel test robot
2022-02-07 10:32 ` David Hildenbrand
2022-02-08 2:05 ` Pedro Gomes
2022-02-08 9:01 ` David Hildenbrand
2022-02-08 13:18 ` Pedro Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACpbsfZN2fExaTReJG1anDQjCd3i24_0wG-oU42dSHD5bAon7A@mail.gmail.com \
--to=pedrodemargomes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).