From: Akshay Bhat <akshay.bhat@timesys.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] rtc: rx8010: Fix for incorrect return value
Date: Wed, 8 Nov 2017 15:00:45 -0500 [thread overview]
Message-ID: <CACrMeVDtSH1dJaw7Ct8c7WTLgYuA1LdOHHQW3LggsK3E5WaRzw@mail.gmail.com> (raw)
In-Reply-To: <20171108023000.4oepp5pyz32c7sr3@piout.net>
On Tue, Nov 7, 2017 at 9:30 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 03/11/2017 at 13:32:41 -0400, Akshay Bhat wrote:
>> if (err != 2)
>> return err < 0 ? err : -EIO;
>> + err = 0;
>
> Isn't it simpler to make the function return 0 instead of err at the end?
Makes sense, fixed in v2 patch, thanks.
next prev parent reply other threads:[~2017-11-08 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 17:32 [PATCH 1/3] rtc: rx8010: Remove duplicate define Akshay Bhat
2017-11-03 17:32 ` [PATCH 2/3] rtc: rx8010: Specify correct address for RX8010_RESV31 Akshay Bhat
2017-11-08 2:28 ` Alexandre Belloni
2017-11-03 17:32 ` [PATCH 3/3] rtc: rx8010: Fix for incorrect return value Akshay Bhat
2017-11-08 2:30 ` Alexandre Belloni
2017-11-08 20:00 ` Akshay Bhat [this message]
2017-11-08 2:28 ` [PATCH 1/3] rtc: rx8010: Remove duplicate define Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACrMeVDtSH1dJaw7Ct8c7WTLgYuA1LdOHHQW3LggsK3E5WaRzw@mail.gmail.com \
--to=akshay.bhat@timesys.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).