From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E880C4338F for ; Mon, 2 Aug 2021 16:20:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10B4660F9E for ; Mon, 2 Aug 2021 16:20:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232573AbhHBQTP (ORCPT ); Mon, 2 Aug 2021 12:19:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbhHBQTD (ORCPT ); Mon, 2 Aug 2021 12:19:03 -0400 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6890BC06175F for ; Mon, 2 Aug 2021 09:18:53 -0700 (PDT) Received: by mail-qv1-xf36.google.com with SMTP id d3so9115986qvq.6 for ; Mon, 02 Aug 2021 09:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZqSi2DWJQSHFbeSWRi1dH74yVKtdTqQrPRmLEYWYlbs=; b=h/XQdhlILCw/+Q5AVlBwggYYgCsNnJTRn3Z6tqiQg/srd2PFd/5P0LfwY976zgfamt Eld7Ds6h/30s7hTfGfyHfhPfU76xhHXb13bScDcPC+XiV1tBNZQaWaRdeX3qiYaWMxQ3 FmpoEwvQv4H3xkX/sbCP3CVkpVKZdsuP95PtxR4hCh3PuAYTg0bOi1oHP/T3s4qJ1iQh y0Hb7Q3hrOymsnDY2hgUm2CmUEOPshqEl/unsvM2yQeaGaYGFn8uNnBe607LszrJoyK0 LKYHiKhZkHNYeuWo4OJR4+0R3gErVUk1M6pp2VyyE60cmsod8V/CYSdZC7/N8mZJDgjF 9Nbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZqSi2DWJQSHFbeSWRi1dH74yVKtdTqQrPRmLEYWYlbs=; b=VtP2oEXiXtKkhB52OK7TRGkdm1CRCFOWebEJDAEx3/qJb/jcwS+Wtn/gqwVDsZDOn1 HE3KQo9yeptmhSp4Gemkgo77YdxFqQ9sPFiua3Skhu0Umx7W7Px7Dd10CDv41jY3Qy1T WQYrC+7H5y2G5HAbOoUNIPLEasBgMtJbvE9gTCWuM9v0qwRdWNYKXP9Esmrl8Cqsooi1 PetT7XakE/uzv8YFEAXKsNvJKnx3hg8lhAJ7MaVFXVzracf648gYeSXh0/vAPIrT29fr dGx15Mgk2ahO1vr8TdBZcQFoxebc3F21viICB8MV+ADD4X24tdxRxZ3MxZjVl9GMF8wz xotw== X-Gm-Message-State: AOAM531hDtq1B2IU14myY3NogRDZpjjLZJgVVF7AZ0zYZ52k3JHbj39Q 0UfXEV/IscyJkElIEQ9d//RPiwd9kzYV0q+tL1s= X-Google-Smtp-Source: ABdhPJwjeKX8dVL7c74Sv+rQlQ8wjBu7odGyPJrq3rHoCjO43yM5Gdqt+HyaXoJwAC2tNgSMrlEBo5d0qlYc/sl1Y10= X-Received: by 2002:a05:6214:1bcf:: with SMTP id m15mr8334112qvc.62.1627921132550; Mon, 02 Aug 2021 09:18:52 -0700 (PDT) MIME-Version: 1.0 References: <20210731214211.657280-1-jim.cromie@gmail.com> <20210731214211.657280-3-jim.cromie@gmail.com> In-Reply-To: <20210731214211.657280-3-jim.cromie@gmail.com> From: Emil Velikov Date: Mon, 2 Aug 2021 17:18:41 +0100 Message-ID: Subject: Re: [PATCH v4 2/7] moduleparam: add data member to struct kernel_param To: Jim Cromie Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Jason Baron , Ashley Thomas , Aurabindo Pillai , Qingqing Zhuo , Wyatt Wood , Jessica Yu , Johan Hovold , Joe Perches , Miguel Ojeda , Nick Desaulniers , ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" , amd-gfx mailing list , intel-gvt-dev@lists.freedesktop.org, Intel Graphics Development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jim, On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote: > Use of this new data member will be rare, it might be worth redoing > this as a separate/sub-type to keep the base case. > > Signed-off-by: Jim Cromie > --- > include/linux/moduleparam.h | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h > index eed280fae433..e9495b1e794d 100644 > --- a/include/linux/moduleparam.h > +++ b/include/linux/moduleparam.h > @@ -78,6 +78,7 @@ struct kernel_param { > const struct kparam_string *str; > const struct kparam_array *arr; > }; > + void *data; Might as well make this "const void *" since it is a compile-time constant? -Emil