From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757485AbcIHNiS (ORCPT ); Thu, 8 Sep 2016 09:38:18 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33822 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755239AbcIHNiP (ORCPT ); Thu, 8 Sep 2016 09:38:15 -0400 MIME-Version: 1.0 In-Reply-To: <1473244056-10157-1-git-send-email-tomeu.vizoso@collabora.com> References: <1473244056-10157-1-git-send-email-tomeu.vizoso@collabora.com> From: Emil Velikov Date: Thu, 8 Sep 2016 14:38:12 +0100 Message-ID: Subject: Re: [Intel-gfx] [PATCH v6 0/4] New debugfs API for capturing CRC of frames To: Tomeu Vizoso Cc: "Linux-Kernel@Vger. Kernel. Org" , linux-doc@vger.kernel.org, David Airlie , "intel-gfx@lists.freedesktop.org" , Jonathan Corbet , Thierry Reding , ML dri-devel , Daniel Vetter , Emil Velikov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7 September 2016 at 11:27, Tomeu Vizoso wrote: > Hi, > > this series basically takes the facility for continuously capturing CRCs > of frames from the i915 driver and into the DRM core. > > The idea is that test suites such as IGT use this information to check > that frames that are exected to be identical, also have identical CRC > values. > > Other drivers for hardware that can provide frame CRCs (including eDP > panels that support self-refresh) can easily implement the new callback > and provide userspace with the CRC values. > > Thanks, > > Tomeu > > Tomeu Vizoso (4): > drm/i915/debugfs: Move out pipe CRC code > drm: Add API for capturing frame CRCs > drm/i915: Use new CRC debugfs API > drm/i915: Put "cooked" vlank counters in frame CRC lines > Thanks for the nice work and addressing my suggestions Tomeu. I think I've spotted a bug in 2/4, plus there's a couple of trivial nitpicks in 2/4 and 3/4 - either of which can be fixed as a follow up (if I haven't lost it of course). With the bug trivially fixed the series is: Reviewed-by: Emil Velikov -Emil