From: Emil Velikov <emil.l.velikov@gmail.com>
To: tang pengchuan <kevin3.tang@gmail.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Orson Zhai <orsonzhai@gmail.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Baolin Wang <baolin.wang@linaro.org>
Subject: Re: [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver
Date: Wed, 11 Dec 2019 11:46:06 +0000 [thread overview]
Message-ID: <CACvgo50wCKq76Wj0xjJcuWxz5gvaOSbj1Hz8-Vi6eOSGH106yg@mail.gmail.com> (raw)
In-Reply-To: <CAFPSGXZMmfeBxkNhuNR59bX26_69_y5C13P7qY-UawVDa7Q3Jw@mail.gmail.com>
On Wed, 11 Dec 2019 at 09:18, tang pengchuan <kevin3.tang@gmail.com> wrote:
>
> Hi
>
> Emil Velikov <emil.l.velikov@gmail.com> 于2019年12月11日周三 上午1:14写道:
>>
>> Hi Kevin,
>>
>> On Tue, 10 Dec 2019 at 08:41, Kevin Tang <kevin3.tang@gmail.com> wrote:
>> >
>> > From: Kevin Tang <kevin.tang@unisoc.com>
>> >
>> > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem.
>> > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more.
>> >
>> > Cc: Orson Zhai <orsonzhai@gmail.com>
>> > Cc: Baolin Wang <baolin.wang@linaro.org>
>> > Cc: Chunyan Zhang <zhang.lyra@gmail.com>
>> > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
>> > ---
>> > drivers/gpu/drm/sprd/Makefile | 6 +-
>> > drivers/gpu/drm/sprd/disp_lib.c | 290 +++++++
>> > drivers/gpu/drm/sprd/disp_lib.h | 40 +
>> > drivers/gpu/drm/sprd/dpu/Makefile | 8 +
>> > drivers/gpu/drm/sprd/dpu/dpu_r2p0.c | 1464 +++++++++++++++++++++++++++++++++++
>> > drivers/gpu/drm/sprd/sprd_dpu.c | 1152 +++++++++++++++++++++++++++
>> > drivers/gpu/drm/sprd/sprd_dpu.h | 217 ++++++
>> > 7 files changed, 3176 insertions(+), 1 deletion(-)
>>
>> As we can see from the diff stat this patch is huge. So it would be fairly hard
>> to provide meaningful review as-is.
>>
>> One can combine my earlier suggestion (to keep modeset/atomic out of 2/8), with
>> the following split:
>> - 4/8 add basic atomic modeset support - one format, one rotation 0, no extra
>> attributes
>> - 5/8 add extra formats
>> - 6/8 add extra rotation support
>> - ... add custom attributes
>
> Ok, i will split this patch, upstream modeset and atomic at first. clock, gloabl, enhance, extra
> attributes and so on will be upload later.
Amazing thank you. Please apply the similar logic and split patch 6/8
- that patch is twice larger than this one.
Some small general requests - please use plain text emails (see [1])
and trim unrelated fragments when replying.
Otherwise it is very easy to miss the comment that you and others have made.
HTH
Emil
[1] https://www.lifewire.com/how-to-send-a-message-in-plain-text-from-gmail-1171963
next prev parent reply other threads:[~2019-12-11 11:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 8:36 [PATCH RFC 0/8] Add Unisoc's drm kms module Kevin Tang
2019-12-10 8:36 ` [PATCH RFC 1/8] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang
2019-12-13 9:42 ` Maxime Ripard
2019-12-10 8:36 ` [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master Kevin Tang
2019-12-10 10:32 ` Thomas Zimmermann
[not found] ` <CAFPSGXb-pbmXFXrN7adK1TO+09T8qtJjwk+dK-TidZSsfPqHFg@mail.gmail.com>
2019-12-10 12:47 ` Thomas Zimmermann
2019-12-10 10:41 ` Daniel Vetter
2019-12-10 16:06 ` Emil Velikov
2019-12-10 22:01 ` Daniel Vetter
2019-12-10 8:36 ` [PATCH RFC 3/8] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang
2019-12-13 9:44 ` Maxime Ripard
2019-12-10 8:36 ` [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver Kevin Tang
2019-12-10 10:44 ` Thomas Zimmermann
2019-12-10 17:13 ` Emil Velikov
[not found] ` <CAFPSGXZMmfeBxkNhuNR59bX26_69_y5C13P7qY-UawVDa7Q3Jw@mail.gmail.com>
2019-12-11 11:46 ` Emil Velikov [this message]
2019-12-10 8:36 ` [PATCH RFC 5/8] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang
2019-12-13 9:46 ` Maxime Ripard
2019-12-10 8:36 ` [PATCH RFC 6/8] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang
2019-12-10 8:36 ` [PATCH RFC 7/8] dt-bindings: display: add Unisoc's generic mipi panel bindings Kevin Tang
2019-12-13 9:48 ` Maxime Ripard
2019-12-10 8:36 ` [PATCH RFC 8/8] drm/sprd: add Unisoc's drm generic mipi panel driver Kevin Tang
2019-12-10 18:54 ` [PATCH RFC 0/8] Add Unisoc's drm kms module Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACvgo50wCKq76Wj0xjJcuWxz5gvaOSbj1Hz8-Vi6eOSGH106yg@mail.gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=baolin.wang@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).