From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932387AbbFCQud (ORCPT ); Wed, 3 Jun 2015 12:50:33 -0400 Received: from mail-vn0-f45.google.com ([209.85.216.45]:32772 "EHLO mail-vn0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932330AbbFCQuX (ORCPT ); Wed, 3 Jun 2015 12:50:23 -0400 MIME-Version: 1.0 In-Reply-To: <1433000370-19509-11-git-send-email-mikko.rapeli@iki.fi> References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-11-git-send-email-mikko.rapeli@iki.fi> Date: Wed, 3 Jun 2015 17:50:22 +0100 Message-ID: Subject: Re: [PATCH 10/98] via_drm.h: hide struct via_file_private in userspace From: Emil Velikov To: Mikko Rapeli Cc: "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , linux-api@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mikko, On 30 May 2015 at 16:38, Mikko Rapeli wrote: > Fixes compiler error since list_head is not exported to userspace headers. > > Signed-off-by: Mikko Rapeli > --- > include/uapi/drm/via_drm.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/uapi/drm/via_drm.h b/include/uapi/drm/via_drm.h > index 791531e..34ce658 100644 > --- a/include/uapi/drm/via_drm.h > +++ b/include/uapi/drm/via_drm.h > @@ -272,8 +272,10 @@ typedef struct drm_via_dmablit { > drm_via_blitsync_t sync; > } drm_via_dmablit_t; > > +#ifdef __KERNEL__ > struct via_file_private { > struct list_head obj_list; > }; > +#endif > We might want to follow the example of other drivers (i915) and move it to drivers/gpu/drm/via_drv.h, There are two users of this struct (via_drv.c and via_mm.c), and each one explicitly includes the header. How does that sound ? Same suggestion goes for the equivalent sis patch. Cheers Emil