From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751444AbcGNVUv (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jul 2016 17:20:51 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:35682 "EHLO
	mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750699AbcGNVUu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jul 2016 17:20:50 -0400
MIME-Version: 1.0
In-Reply-To: <1468428258-5601-3-git-send-email-simhavcs@gmail.com>
References: <1468428258-5601-1-git-send-email-simhavcs@gmail.com> <1468428258-5601-3-git-send-email-simhavcs@gmail.com>
From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Thu, 14 Jul 2016 22:20:48 +0100
Message-ID: <CACvgo52ijPMDT=jNpyGTtzzEH4DksNdMC4mzENZZ1NhG0f=Spg@mail.gmail.com>
Subject: Re: [PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness
To: Vinay Simha BN <simhavcs@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        Archit Taneja <archit.taneja@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13 July 2016 at 17:44, Vinay Simha BN <simhavcs@gmail.com> wrote:

> +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
> +                                       u16 *brightness)
> +{
> +       ssize_t err;
> +
> +       err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS,
> +                               brightness, sizeof(*brightness));
> +       if (err < 0) {
> +               if (err == 0)
Something looks fishy here. This can never be true, can it ?

 -Emil