linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Barry Song <Barry.Song@csr.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, workgroup.linux@csr.com,
	linux-mtd@lists.infradead.org, Barry Song <Baohua.Song@csr.com>,
	Erik Gilling <konkers@google.com>,
	Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/3] platform: add common resource requesting and mapping helper
Date: Tue, 31 Jan 2012 14:52:55 -0700	[thread overview]
Message-ID: <CACxGe6srOi97g1OHDAULLcGP95ZGb8AJVURRFJt062HiN43wSg@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdaLekGTdkpfr_Zf5PXAZ16dZsXrwnFHjBe+aEvGb5zYjg@mail.gmail.com>

On Tue, Jan 31, 2012 at 2:20 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Jan 31, 2012 at 11:00 AM, Barry Song <Barry.Song@csr.com> wrote:
>
>> From: Barry Song <Baohua.Song@csr.com>
>>
>> this patch helps to move the common pattern from
>
> Good idea!
>
>> @@ -44,6 +44,7 @@ extern struct device platform_bus;
>>
>>  extern void arch_setup_pdev_archdata(struct platform_device *);
>>  extern struct resource *platform_get_resource(struct platform_device *, unsigned int, unsigned int);
>> +extern void __iomem *platform_devm_request_and_ioremap(struct platform_device *, unsigned int);
>
> But don't you want a reverse call for the module remove() function?
>
> Like:
>
> extern void __iomem *platform_devm_iounmap_and_free(struct
> platform_device *, unsigned int);

I wouldn't because it is exactly the same as the normal unwind call.
I don't think the name redirection buys us anything here.

g.

  reply	other threads:[~2012-01-31 21:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31  9:59 [PATCH 0/3] platform: add platform_devm_request_and_ioremap() common API Barry Song
2012-01-31 10:00 ` [PATCH 1/3] platform: add common resource requesting and mapping helper Barry Song
2012-01-31 10:17   ` Wolfram Sang
2012-01-31 11:04     ` Barry Song
2012-01-31 11:33       ` Wolfram Sang
2012-01-31 12:09         ` Barry Song
2012-01-31 20:34         ` Grant Likely
2012-01-31 21:15           ` Wolfram Sang
2012-01-31 21:51             ` Grant Likely
2012-02-01  2:11             ` Barry Song
2012-02-01 10:03               ` Wolfram Sang
2012-02-01 10:20                 ` Barry Song
2012-02-01 12:56               ` Mark Brown
2012-02-02  0:10                 ` Grant Likely
2012-01-31 20:35   ` Grant Likely
2012-01-31 21:20   ` Linus Walleij
2012-01-31 21:52     ` Grant Likely [this message]
2012-02-01  2:22     ` Barry Song
2012-01-31 10:00 ` [PATCH 2/3] GPIO: TEGRA: move to use platform_devm_request_and_ioremap() helper Barry Song
2012-01-31 16:55   ` Stephen Warren
2012-01-31 20:37   ` Grant Likely
2012-01-31 10:00 ` [PATCH 3/3] MTD: NAND: txx9ndfmc: " Barry Song
2012-01-31 11:14 ` [PATCH 0/3] platform: add platform_devm_request_and_ioremap() common API Artem Bityutskiy
2012-01-31 12:57   ` Barry Song
2012-01-31 13:16     ` Artem Bityutskiy
2012-01-31 13:23       ` Artem Bityutskiy
2012-01-31 13:27         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACxGe6srOi97g1OHDAULLcGP95ZGb8AJVURRFJt062HiN43wSg@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=Baohua.Song@csr.com \
    --cc=Barry.Song@csr.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@suse.de \
    --cc=konkers@google.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=workgroup.linux@csr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).