From: Grant Likely <grant.likely@secretlab.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
Rob Herring <rob.herring@calxeda.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] of: Make device nodes kobjects so they show up in sysfs
Date: Wed, 20 Mar 2013 21:28:01 +0000 [thread overview]
Message-ID: <CACxGe6vw5sevcv=NgeQDhH1QuGgTphia-AnKbSQkVm64tSgNSA@mail.gmail.com> (raw)
In-Reply-To: <1363791432.12701.8.camel@pasglop>
On Wed, Mar 20, 2013 at 2:57 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Wed, 2013-03-20 at 14:51 +0000, Grant Likely wrote:
>> Both of the above problems can be worked around by using
>> sysfs_create_bin_file() instead of sysfs_create_file(), but doing so
>> adds an additional 20 to 40 bytes of overhead per property. A device
>> tree has a lot of properties in it. That overhead will very quickly add
>> up. The other option is to create a new custom sysfs attribute type
>> would solve the problem without additional overhead, but at the cost of
>> more complexity in the sysfs support code. However, I'm hopeful that
>> these problems are just imaginary and we can stick with normal sysfs
>> attributes.
>
> Disagreed. It would break stuff, especially the incorrect file size.
I retried with bin files. Turns out I should stop making assumptions
and actually try things. It requires less code, is simpler and pretty
much eliminates the issues listed above. :-)
I'll post a new series with the fixes.
g.
next prev parent reply other threads:[~2013-03-20 21:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 14:51 [PATCH 0/2] of: Create sysfs view of device tree nodes Grant Likely
2013-03-20 14:51 ` [PATCH 1/2] of: Make device nodes kobjects so they show up in sysfs Grant Likely
2013-03-20 14:57 ` Benjamin Herrenschmidt
2013-03-20 16:56 ` Greg Kroah-Hartman
2013-03-20 17:46 ` Benjamin Herrenschmidt
2013-03-20 21:28 ` Grant Likely [this message]
2013-03-20 14:51 ` [PATCH 2/2] of: remove /proc/device-tree Grant Likely
2013-03-20 14:57 ` Benjamin Herrenschmidt
2013-03-20 21:38 ` Grant Likely
2013-03-21 4:19 ` Benjamin Herrenschmidt
2013-03-21 7:35 ` Grant Likely
2013-03-21 7:43 ` Benjamin Herrenschmidt
2013-03-21 8:16 ` Grant Likely
2013-03-21 12:36 ` Benjamin Herrenschmidt
2013-03-21 12:42 ` Grant Likely
2013-11-16 20:09 ` Geert Uytterhoeven
2013-03-20 15:19 ` Rob Herring
2013-03-20 16:24 ` Daniel Mack
2013-03-20 16:40 ` Grant Likely
2013-03-21 4:03 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACxGe6vw5sevcv=NgeQDhH1QuGgTphia-AnKbSQkVm64tSgNSA@mail.gmail.com' \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).