From: Wenwei Tao <ww.tao0320@gmail.com>
To: "Matias Bjørling" <m@bjorling.me>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] lightnvm: fix media mgr registration
Date: Fri, 4 Dec 2015 16:40:41 +0800 [thread overview]
Message-ID: <CACygaLACFHjoRyhNTE8iYza1PpWwvJjKs7gFH=gB9psB_r54+g@mail.gmail.com> (raw)
In-Reply-To: <1449058583-27940-3-git-send-email-m@bjorling.me>
2015-12-02 20:16 GMT+08:00 Matias Bjørling <m@bjorling.me>:
> The ppa pool can be used at media manager registration.
> Therefore the ppa pool should be allocated before registering.
>
> If a media manager can't be found, this should not lead to the
> device being unallocated. A media manager can be registered later, that
> can manage a device. Only warn if a media manager fails initialization.
>
> Additionally, protect against the media managed being registered or
> deregistered while looping through available media managers. This was
> reported by Wenwei Tao.
>
> Signed-off-by: Matias Bjørling <m@bjorling.me>
> ---
> drivers/lightnvm/core.c | 79 ++++++++++++++++++++++++-------------------------
> 1 file changed, 39 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 4601cf1..f4d5291 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -97,15 +97,47 @@ static struct nvmm_type *nvm_find_mgr_type(const char *name)
> return NULL;
> }
>
> +struct nvmm_type *nvm_init_mgr(struct nvm_dev *dev)
> +{
> + struct nvmm_type *mt;
> + int ret;
> +
> + lockdep_assert_held(&nvm_lock);
> +
> + list_for_each_entry(mt, &nvm_mgrs, list) {
> + ret = mt->register_mgr(dev);
> + if (ret < 0) {
> + pr_err("nvm: media mgr failed to init (%d) on dev %s\n",
> + ret, dev->name);
> + return NULL; /* initialization failed */
Do we just return or continue to try next media manager ? In my commit
commit d0a712ceb83ebaea32d520825ee7b997f59b168f
Author: Wenwei Tao <ww.tao0320@gmail.com>
Date: Sat Nov 28 16:49:28 2015 +0100
lightnvm: missing nvm_lock acquire
I use the second solution.
> + } else if (ret > 0)
> + return mt;
> + }
> +
> + return NULL;
> +}
> +
next prev parent reply other threads:[~2015-12-04 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 12:16 [PATCH RFC 1/3] lightnvm: check mm before use Matias Bjørling
2015-12-02 12:16 ` [PATCH RFC 2/3] lightnvm: comments on constants Matias Bjørling
2015-12-02 12:16 ` [PATCH RFC 3/3] lightnvm: fix media mgr registration Matias Bjørling
2015-12-04 8:40 ` Wenwei Tao [this message]
2015-12-04 10:46 ` Matias Bjørling
2015-12-04 8:02 ` [PATCH RFC 1/3] lightnvm: check mm before use Wenwei Tao
2015-12-04 9:51 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACygaLACFHjoRyhNTE8iYza1PpWwvJjKs7gFH=gB9psB_r54+g@mail.gmail.com' \
--to=ww.tao0320@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).