From: Wincy Van <fanwenyi0529@gmail.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"gleb@kernel.org" <gleb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Wanpeng Li <wanpeng.li@linux.intel.com>,
Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH v4 0/6] KVM: nVMX: Enable nested apicv support
Date: Thu, 29 Jan 2015 13:31:45 +0800 [thread overview]
Message-ID: <CACzj_yXGqUy4rJCTe8XVWYfSvdvD+t_1dptNrEoYJKd=0=MBZA@mail.gmail.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E0AC2E2F6@SHSMSX104.ccr.corp.intel.com>
On Thu, Jan 29, 2015 at 11:17 AM, Zhang, Yang Z <yang.z.zhang@intel.com> wrote:
> Wincy Van wrote on 2015-01-28:
>> v1 ---> v2:
>> Use spin lock to ensure vmcs12 is safe when doing nested
>> posted interrupt delivery.
>> v2 ---> v3:
>> 1. Add a new field in nested_vmx to avoid the spin lock in v2.
>> 2. Drop send eoi to L1 when doing nested interrupt delivery.
>> 3. Use hardware MSR bitmap to enable nested virtualize x2apic
>> mode.
>> v3 ---> v4:
>> 1. Optimize nested msr bitmap merging.
>> 2. Allocate nested msr bitmap only when nested == 1.
>> 3. Inline the nested vmx control checking functions.
>
> This version looks good to me. Only minor comment: EXIT_REASON_APIC_WRITE vmexit is introduced by apic register virtualization not virtual interrupt delivery, so it's better add it in 4th patch not 5th patch.(If no other comments, I guess Paolo can help do it when applying it).
>
> Reviewed-by: Yang Zhang <yang.z.zhang@intel.com>
>
Yes, thank you for pointing out it ; )
Paolo, what's your opinion?
Thanks,
Wincy
prev parent reply other threads:[~2015-01-29 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 15:49 [PATCH v4 0/6] KVM: nVMX: Enable nested apicv support Wincy Van
2015-01-29 3:17 ` Zhang, Yang Z
2015-01-29 5:31 ` Wincy Van [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACzj_yXGqUy4rJCTe8XVWYfSvdvD+t_1dptNrEoYJKd=0=MBZA@mail.gmail.com' \
--to=fanwenyi0529@gmail.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=wanpeng.li@linux.intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).