From: harshad shirwadkar <harshadshirwadkar@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Ritesh Harjani <riteshh@linux.ibm.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 7/9] ext4: Fix remaining two trace events to use same printk convention
Date: Sun, 27 Feb 2022 10:32:29 -0800 [thread overview]
Message-ID: <CAD+ocbwL6jCtUgqjp5VzLkyab6wZurF=cCB9ZJOawJaejJv32A@mail.gmail.com> (raw)
In-Reply-To: <20220223094509.asn3e4dcgs5fokeo@quack3.lan>
Looks good.
Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
- Harshad
On Wed, 23 Feb 2022 at 01:45, Jan Kara <jack@suse.cz> wrote:
>
> On Wed 23-02-22 02:04:15, Ritesh Harjani wrote:
> > All ext4 & jbd2 trace events starts with "dev Major:Minor".
> > While we are still improving/adding the ftrace events for FC,
> > let's fix last two remaining trace events to follow the same
> > convention.
> >
> > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
>
> OK. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
>
> > ---
> > include/trace/events/ext4.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
> > index 6e66cb7ce624..233dbffa5ceb 100644
> > --- a/include/trace/events/ext4.h
> > +++ b/include/trace/events/ext4.h
> > @@ -2653,7 +2653,7 @@ TRACE_EVENT(ext4_fc_replay_scan,
> > __entry->off = off;
> > ),
> >
> > - TP_printk("FC scan pass on dev %d,%d: error %d, off %d",
> > + TP_printk("dev %d,%d error %d, off %d",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->error, __entry->off)
> > );
> > @@ -2679,7 +2679,7 @@ TRACE_EVENT(ext4_fc_replay,
> > __entry->priv2 = priv2;
> > ),
> >
> > - TP_printk("FC Replay %d,%d: tag %d, ino %d, data1 %d, data2 %d",
> > + TP_printk("dev %d,%d: tag %d, ino %d, data1 %d, data2 %d",
> > MAJOR(__entry->dev), MINOR(__entry->dev),
> > __entry->tag, __entry->ino, __entry->priv1, __entry->priv2)
> > );
> > --
> > 2.31.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
next prev parent reply other threads:[~2022-02-27 18:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 20:34 [RFC 0/9] ext4: Improve FC trace events and discuss one FC failure Ritesh Harjani
2022-02-22 20:34 ` [RFC 1/9] ext4: Remove unused enum EXT4_FC_COMMIT_FAILED Ritesh Harjani
2022-02-23 9:37 ` Jan Kara
2022-02-27 18:27 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 2/9] ext4: Fix ext4_fc_stats trace point Ritesh Harjani
2022-02-22 20:52 ` Steven Rostedt
2022-02-23 9:54 ` Jan Kara
2022-02-27 18:29 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 3/9] ext4: Add couple of more fast_commit tracepoints Ritesh Harjani
2022-02-23 9:40 ` Jan Kara
2022-02-23 10:11 ` Ritesh Harjani
2022-02-23 11:53 ` Jan Kara
2022-02-23 12:04 ` Ritesh Harjani
2022-02-22 20:34 ` [RFC 4/9] ext4: Do not call FC trace event if FS does not support FC Ritesh Harjani
2022-02-23 9:41 ` Jan Kara
2022-02-27 18:30 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 5/9] ext4: Add commit_tid info in jbd debug log Ritesh Harjani
2022-02-23 9:42 ` Jan Kara
2022-02-27 18:31 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 6/9] ext4: Add commit tid info in ext4_fc_commit_start/stop trace events Ritesh Harjani
2022-02-23 9:44 ` Jan Kara
2022-02-27 18:31 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 7/9] ext4: Fix remaining two trace events to use same printk convention Ritesh Harjani
2022-02-23 9:45 ` Jan Kara
2022-02-27 18:32 ` harshad shirwadkar [this message]
2022-02-22 20:34 ` [RFC 8/9] ext4: Convert ext4_fc_track_dentry type events to use event class Ritesh Harjani
2022-02-23 9:49 ` Jan Kara
2022-02-27 18:35 ` harshad shirwadkar
2022-02-22 20:34 ` [RFC 9/9] ext4: fast_commit missing tracking updates to a file Ritesh Harjani
2022-02-23 3:50 ` [External] " Xin Yin
2022-02-23 13:58 ` Ritesh Harjani
2022-02-24 11:43 ` Xin Yin
2022-02-27 20:51 ` harshad shirwadkar
2022-03-09 17:48 ` [RFC 0/9] ext4: Improve FC trace events and discuss one FC failure Theodore Ts'o
2022-03-10 1:22 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+ocbwL6jCtUgqjp5VzLkyab6wZurF=cCB9ZJOawJaejJv32A@mail.gmail.com' \
--to=harshadshirwadkar@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).