From: Dongliang Mu <mudongliangabcd@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: Need help in debugging "memory leak in em28xx_init_dev"
Date: Mon, 1 Nov 2021 20:23:29 +0800 [thread overview]
Message-ID: <CAD-N9QUcoKnEWw98XnBJZkas3AkwPonNG0K-PMROOwn8kReT5g@mail.gmail.com> (raw)
In-Reply-To: <28a3777a-7941-6ffc-07e5-38456372cfb3@gmail.com>
On Mon, Nov 1, 2021 at 8:17 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
>
> On 11/1/21 12:58, Dongliang Mu wrote:
> > On Mon, Nov 1, 2021 at 5:43 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
> >>
> >> On 11/1/21 12:41, Dongliang Mu wrote:
> >> >> Hi, Dongliang,
> >> >>
> >> >> Did patch attached to my previous email pass syzbot's reproducer test?
> >> >> Unfortunately, I am not able to test rn :(
> >> >
> >> > Yes, it works. The memory leak does not occur anymore.
> >> >
> >> > But I am crafting another patch based on yours as there is a small
> >> > issue in the retval and I would like to make the error handling code
> >> > uniform.
> >> >
> >>
> >> Cool! Thank you for confirmation.
> >
> > Hi Pavel,
> >
> > Thanks for your advice. I have sent the patch and you are on the CC
> > list. Can you please take a look at and review my patch?
> >
> > It should cover your patch. But I am not sure if I introduce any new
> > issue in the patch.
> >
>
> The patch LGTM, but I can't drop R-b tag, since I am not an expert in
> this driver. Anyway, there is 100% missing clean up, so, I believe, you
> don't introduce new bugs
drop? I do see some patches from local syzkaller will attach this tag
to assign credits to syzkaller/syzbot.
I think this form is good. Thus I copy this tag from them.
>
>
>
> With regards,
> Pavel Skripkin
next prev parent reply other threads:[~2021-11-01 12:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 3:02 Need help in debugging "memory leak in em28xx_init_dev" Dongliang Mu
2021-11-01 7:50 ` Pavel Skripkin
2021-11-01 8:55 ` Dongliang Mu
2021-11-01 9:19 ` Pavel Skripkin
2021-11-01 9:41 ` Dongliang Mu
2021-11-01 9:43 ` Pavel Skripkin
2021-11-01 9:58 ` Dongliang Mu
2021-11-01 12:17 ` Pavel Skripkin
2021-11-01 12:23 ` Dongliang Mu [this message]
2021-11-01 12:26 ` Pavel Skripkin
2021-11-01 12:31 ` Dongliang Mu
2021-11-01 14:30 ` Dan Carpenter
2021-11-01 14:33 ` Dongliang Mu
2021-11-01 15:05 ` Randy Dunlap
2021-11-01 18:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD-N9QUcoKnEWw98XnBJZkas3AkwPonNG0K-PMROOwn8kReT5g@mail.gmail.com \
--to=mudongliangabcd@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paskripkin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).