From: Dongliang Mu <mudongliangabcd@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
stable@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tty: nozomi: tty_unregister_device -> tty_port_unregister_device
Date: Wed, 21 Jul 2021 20:53:47 +0800 [thread overview]
Message-ID: <CAD-N9QVLshn_A=S+Nqemc9BRUdW432VrLJCAb=t35WaoL-C3=Q@mail.gmail.com> (raw)
In-Reply-To: <YPgMZBK/FWLRD1Ic@hovoldconsulting.com>
On Wed, Jul 21, 2021 at 8:01 PM Johan Hovold <johan@kernel.org> wrote:
>
> On Wed, Jul 21, 2021 at 07:33:04PM +0800, Dongliang Mu wrote:
> > The pairwise api invocation of tty_port_register_device should be
> > tty_port_unregister_device, other than tty_unregister_device.
>
> Are you sure about that? Please explain why you think this to be the
> case and why this change is needed.
I am sure about this.
1. From the implementation,
tty_port_register_device -> tty_port_register_device_attr ->
tty_port_link_device; tty_register_device_attr
tty_register_device -> tty_register_device_attr
tty_port_unregister_device -> serdev_tty_port_unregister;
tty_unregister_device
tty_unregister_device
As to the functionability, tty_port_register_device pairs with
tty_port_unregister_device; meanwhile, the same to tty_register_device
and tty_unregister_device.
2. From the function naming style,
tty_port_register_device - tty_port_unregister_device;
tty_register_device - tty_unregister_device
>
> > Fixes: a6afd9f3e819 ("tty: move a number of tty drivers from drivers/char/ to drivers/tty/")
>
> Please try a little harder, that's clearly not the commit that changed
> to the port registration helper.
>
> > Cc: stable@vger.kernel.org
>
> Why do you think this is stable material? (hint: it is not)
From the documentation, this label could make the patch automatically
go to stable tree. And stable tree is also using the incorrect api.
If I have any misunderstanding, please let me know.
>
> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > ---
> > drivers/tty/nozomi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
> > index 0c80f25c8c3d..08bdd82f60b5 100644
> > --- a/drivers/tty/nozomi.c
> > +++ b/drivers/tty/nozomi.c
> > @@ -1417,7 +1417,8 @@ static int nozomi_card_init(struct pci_dev *pdev,
> >
> > err_free_tty:
> > for (i--; i >= 0; i--) {
> > - tty_unregister_device(ntty_driver, dc->index_start + i);
> > + tty_port_unregister_device(&dc->port[i].port, ntty_driver,
> > + dc->index_start + i);
> > tty_port_destroy(&dc->port[i].port);
> > }
> > free_irq(pdev->irq, dc);
>
> Johan
next prev parent reply other threads:[~2021-07-21 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 11:33 [PATCH v2] tty: nozomi: tty_unregister_device -> tty_port_unregister_device Dongliang Mu
2021-07-21 12:00 ` Johan Hovold
2021-07-21 12:53 ` Dongliang Mu [this message]
2021-07-21 13:09 ` Johan Hovold
2021-07-21 13:35 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD-N9QVLshn_A=S+Nqemc9BRUdW432VrLJCAb=t35WaoL-C3=Q@mail.gmail.com' \
--to=mudongliangabcd@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregkh@suse.de \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).