From: Dongliang Mu <mudongliangabcd@gmail.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Dongliang Mu <dzm91@hust.edu.cn>,
Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: cdns3: remove dead code
Date: Wed, 28 Sep 2022 15:04:55 +0800 [thread overview]
Message-ID: <CAD-N9QWXPf0_d=mEJ3c6NNfw1V9kdTm66+-jUT9heD4Z+L6kHQ@mail.gmail.com> (raw)
In-Reply-To: <8db6ca9c-6ceb-001e-3427-c7e320111d80@kernel.org>
On Wed, Sep 28, 2022 at 2:50 PM Roger Quadros <rogerq@kernel.org> wrote:
>
>
>
> On 26/09/2022 16:59, Dongliang Mu wrote:
> > From: Dongliang Mu <mudongliangabcd@gmail.com>
> >
> > Smatch reports the following error:
> >
> > drivers/usb/cdns3/cdns3-plat.c:113 cdns3_plat_probe() warn:
> > platform_get_irq() does not return zero
> >
> > From the document, platform_get_irq_byname_optional only returns
> > non-zero value, and negative value on failure.
> >
> > Fix this by removing the zero value checking.
> >
> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
Hi Roger,
By simply checking the usage of API - platform_get_irq_byname_optional,
there are several issues in other code sites.
However, some code sites are related to semantics. I will analyze all
of them and submit patches later.
>
> > ---
> > drivers/usb/cdns3/cdns3-plat.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
> > index dc068e940ed5..2bc5d094548b 100644
> > --- a/drivers/usb/cdns3/cdns3-plat.c
> > +++ b/drivers/usb/cdns3/cdns3-plat.c
> > @@ -110,8 +110,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
> > cdns->wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup");
> > if (cdns->wakeup_irq == -EPROBE_DEFER)
> > return cdns->wakeup_irq;
> > - else if (cdns->wakeup_irq == 0)
> > - return -EINVAL;
> >
> > if (cdns->wakeup_irq < 0) {
> > dev_dbg(dev, "couldn't get wakeup irq\n");
>
>
> cheers,
> -roger
prev parent reply other threads:[~2022-09-28 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 13:59 [PATCH] usb: cdns3: remove dead code Dongliang Mu
2022-09-28 6:40 ` Pawel Laszczak
2022-09-28 6:49 ` Roger Quadros
2022-09-28 6:57 ` Dongliang Mu
2022-09-28 6:49 ` Roger Quadros
2022-09-28 7:04 ` Dongliang Mu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD-N9QWXPf0_d=mEJ3c6NNfw1V9kdTm66+-jUT9heD4Z+L6kHQ@mail.gmail.com' \
--to=mudongliangabcd@gmail.com \
--cc=a-govindraju@ti.com \
--cc=dzm91@hust.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).