From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341C2C432BE for ; Fri, 23 Jul 2021 05:17:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E286600D3 for ; Fri, 23 Jul 2021 05:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230459AbhGWEgd (ORCPT ); Fri, 23 Jul 2021 00:36:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbhGWEgc (ORCPT ); Fri, 23 Jul 2021 00:36:32 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92164C061575; Thu, 22 Jul 2021 22:17:05 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id hq13so1870043ejc.7; Thu, 22 Jul 2021 22:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4fI8ac75Jl7XkViy3WmvkEADCAEIISOht2OQ8lV/JwY=; b=QOMUzuWEbDWtxSPRyKcMbBPR4hijoobas5DF7t8nAUQIH2jYK6jE1Xui5vPVm9RHqL S5jXKRo26bk3aQPVjuyVcMO3PLWwa8vsFs76PyXEV0ovS75DyHI0rq3p9joduEGCUlG5 SfETEmGG293f3H5ompvDlXIYHSuZOxxPBZLlkdL+m7//kFGtZ64tPqK2mwJDEKDCe6JW Mi6GAvcGmfIOTbj28LbuX9yghzqAcQ2GyhZp6Rt6pjiuBfxzKLZEXgil2YcILNtq4So9 ubNIXkYNxbhjje6GpSGtifYjemhzvTsZtWbitbOyxgsGlLDtw3w+VaUGfB7lvgsBdgdA YRtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4fI8ac75Jl7XkViy3WmvkEADCAEIISOht2OQ8lV/JwY=; b=iz4+qVQY+6RcGidEjM5RwAyy/owG6P1OF0zQiR2Vx8lraKJELQxs9p1FDVKaM09Xy4 1oqGV5bQSQ85LC7vSSav6dniBJYt8vmoARaKyMNQLJAgVifvqe54K0E6eHJ2s4ozLqfc 8d0vgFGrvauEpFdhtJJy0YhBAwu9LOOMb/bEvu6dLfWgJa/7+clDlEZSx+6S+4+YgqF3 CFudHA3qt2jrZTSwANbTV/VsyJHLcX/PsEGfFcl1+OwZZMf+wRSn8wRf0mRo8E/GtbJe lnpxuSCiQ7UZ/fkTeSmPDZMbSXo24ds7yJgdf0B6OLmZDlocedYWVKZlx75C1ZM2B93Y GWwQ== X-Gm-Message-State: AOAM532SL5KVbCI7SXPDopaMckPVp/USWFjlkxMFNm0DCfthModmmGEy BSnhuXsoAwFkBTvNmXde0NrC+v0zzxb3kdbyMKE= X-Google-Smtp-Source: ABdhPJwGBmgX0TfAcA05Q95agluIQrElbzEpwJKnItPJoS50x3rQc1cay9rXaObVWzQ+yRkHEKfdxd0SXUPJfAw1oiU= X-Received: by 2002:a17:906:eda7:: with SMTP id sa7mr3123620ejb.135.1627017423990; Thu, 22 Jul 2021 22:17:03 -0700 (PDT) MIME-Version: 1.0 References: <20210723050919.1910964-1-mudongliangabcd@gmail.com> In-Reply-To: <20210723050919.1910964-1-mudongliangabcd@gmail.com> From: Dongliang Mu Date: Fri, 23 Jul 2021 13:16:37 +0800 Message-ID: Subject: Re: [PATCH] cfg80211: free the object allocated in wiphy_apply_custom_regulatory To: Johannes Berg , Kalle Valo , "David S. Miller" , Jakub Kicinski , Luca Coelho , Ilan Peer Cc: syzbot+1638e7c770eef6b6c0d0@syzkaller.appspotmail.com, Johannes Berg , linux-wireless@vger.kernel.org, "open list:NETWORKING [GENERAL]" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2021 at 1:09 PM Dongliang Mu wrote: > > The commit beee24695157 ("cfg80211: Save the regulatory domain when > setting custom regulatory") forgets to free the newly allocated regd > object. > > Fix this by freeing the regd object in the error handling code and > deletion function - mac80211_hwsim_del_radio. > > Reported-by: syzbot+1638e7c770eef6b6c0d0@syzkaller.appspotmail.com > Fixes: beee24695157 ("cfg80211: Save the regulatory domain when setting custom regulatory") > Signed-off-by: Dongliang Mu > --- > drivers/net/wireless/mac80211_hwsim.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c > index ffa894f7312a..20b870af6356 100644 > --- a/drivers/net/wireless/mac80211_hwsim.c > +++ b/drivers/net/wireless/mac80211_hwsim.c > @@ -3404,6 +3404,8 @@ static int mac80211_hwsim_new_radio(struct genl_info *info, > debugfs_remove_recursive(data->debugfs); > ieee80211_unregister_hw(data->hw); > failed_hw: > + if (param->regd) > + kfree_rcu(get_wiphy_regdom(data->hw->wiphy)); Here kfree_rcu supports only 1 parameter. But some example code uses the 2nd parameter: rcu_head or rcu. For example, static void rcu_free_regdom(const struct ieee80211_regdomain *r) { ...... kfree_rcu((struct ieee80211_regdomain *)r, rcu_head); } If this patch has any issues, please let me know. > device_release_driver(data->dev); > failed_bind: > device_unregister(data->dev); > @@ -3454,6 +3456,8 @@ static void mac80211_hwsim_del_radio(struct mac80211_hwsim_data *data, > { > hwsim_mcast_del_radio(data->idx, hwname, info); > debugfs_remove_recursive(data->debugfs); > + if (data->regd) > + kfree_rcu(get_wiphy_regdom(data->hw->wiphy)); > ieee80211_unregister_hw(data->hw); > device_release_driver(data->dev); > device_unregister(data->dev); > -- > 2.25.1 >