From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752867AbdJGOd4 (ORCPT ); Sat, 7 Oct 2017 10:33:56 -0400 Received: from mail-ua0-f195.google.com ([209.85.217.195]:32991 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbdJGOdz (ORCPT ); Sat, 7 Oct 2017 10:33:55 -0400 X-Google-Smtp-Source: AOwi7QBoCzPd+4m9lCpdhbSPo7Y8unqLOR+iLcwZAecNeLAb60+4s3iy55fd+sYI4aOU6Ujh3Fyub+Hd8G7jFQs1wM4= MIME-Version: 1.0 In-Reply-To: <1507383097084-400953728-9-diffsplit-thomas@m3y3r.de> References: <1507383097081-778026979-0-diffsplit-thomas@m3y3r.de> <1507383097084-400953728-9-diffsplit-thomas@m3y3r.de> From: Ju Hyung Park Date: Sat, 7 Oct 2017 23:33:54 +0900 Message-ID: Subject: Re: [f2fs-dev] [PATCH] f2fs: Fix bool initialization/comparison To: Thomas Meyer Cc: "jaegeuk@kernel.org" , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Isn't this bogus? "bool" type in Linux kernel is a typedef to "_Bool" and true/false is defined as 1 and 0 by enum at include/linux/stddef.h. On Sat, Oct 7, 2017 at 11:02 PM, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/fs/f2fs/data.c b/fs/f2fs/data.c > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -419,7 +419,7 @@ next: > bio_page = fio->encrypted_page ? fio->encrypted_page : fio->page; > > /* set submitted = 1 as a return value */ > - fio->submitted = 1; > + fio->submitted = true; > > inc_page_count(sbi, WB_DATA_TYPE(bio_page)); > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel