From: Valentin Rothberg <valentinrothberg@gmail.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Greg KH <gregkh@linuxfoundation.org>,
hengelein Stefan <stefan.hengelein@fau.de>,
linux-kernel@vger.kernel.org,
Andreas Ruprecht <rupran@einserver.de>
Subject: Re: [PATCH] checkkconfigsymbols.py: make it Git aware
Date: Sat, 14 Mar 2015 17:28:08 +0100 [thread overview]
Message-ID: <CAD3Xx4LEL3UKgoiXQ3fgHWQPJ2hhR4ULsCR4F3LrFdoa7K-MFg@mail.gmail.com> (raw)
In-Reply-To: <1426278008.7778.27.camel@x220>
On Fri, Mar 13, 2015 at 9:20 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Wed, 2015-03-11 at 16:04 +0100, Valentin Rothberg wrote:
>> Paul, how long does your monster run? Maybe I just call it wrong or
>> mess up with caches.
>
> Even longer, I presume. Because an update for just a new linux next
> release can take over a minute on my fastest machine (a ThinkPad X220).
>
> (Recall that my monster runs daily over just the blobs added to the tree
> for the latest linux-next tag and stores an intermediate parse as a git
> note to each of those new blobs. It then does a second parse of all the
> git notes relevant for that tag and stores the final result as a git
> note to that tag.
>
> And I do all this to make the daily update run at a decent speed. A
> downside of this approach is that the very first run, which has to
> parse, say, 50.000 new blobs, takes ages.)
Thank you for the explanation. I was really surprised how long
(compared to reset) it takes.
> My suggestion won't do here. So let me just say that messing with the
> state of peoples repository might make you the target of a flame or two.
> Are you sure you want to go down that route?
In case running the script would delete one's day of work or worse ...
no ... I don't want to take responsibility for that. The patch at the
current state is unacceptable, but I see two options to solve the
issue while being fast:
(1) Test if the current tree is dirty, warn the user and ask if she
wants to continue or not.
(2) Abort if the tree is dirty.
Personally, I prefer option 2. The script would still be fast, and
there is no way that it deletes data by accident.
Kind regards,
Valentin
next prev parent reply other threads:[~2015-03-14 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 11:16 [PATCH] checkkconfigsymbols.py: make it Git aware Valentin Rothberg
2015-03-11 12:04 ` Paul Bolle
2015-03-11 14:19 ` Valentin Rothberg
2015-03-11 14:33 ` Valentin Rothberg
2015-03-11 15:04 ` Valentin Rothberg
2015-03-13 20:20 ` Paul Bolle
2015-03-14 16:28 ` Valentin Rothberg [this message]
2015-03-16 10:38 ` [PATCH v2] " Valentin Rothberg
2015-03-16 11:16 ` [PATCH v3] " Valentin Rothberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD3Xx4LEL3UKgoiXQ3fgHWQPJ2hhR4ULsCR4F3LrFdoa7K-MFg@mail.gmail.com \
--to=valentinrothberg@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rupran@einserver.de \
--cc=stefan.hengelein@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).