From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753365AbbAMP7i (ORCPT ); Tue, 13 Jan 2015 10:59:38 -0500 Received: from mail-wi0-f175.google.com ([209.85.212.175]:48007 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753312AbbAMP7f (ORCPT ); Tue, 13 Jan 2015 10:59:35 -0500 MIME-Version: 1.0 In-Reply-To: References: <54584260.8030602@nvidia.com> <545895B2.2000101@nvidia.com> Date: Tue, 13 Jan 2015 07:59:33 -0800 Message-ID: Subject: Re: Possible regression with commit 52221610d From: Tim Kryger To: Bjorn Andersson Cc: Ulf Hansson , Alexandre Courbot , Sachin Kamat , linux-mmc , "linux-kernel@vger.kernel.org" , Alexandre Courbot , linux-arm-msm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 5, 2015 at 11:52 AM, Bjorn Andersson wrote: > On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: >> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: > [..] >>> Non-the-less, feel free to propose a patch and I will give it a test. >> >> Lets start with the simplest change first. Please give this a try and >> let me know what you think. >> >> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c >> index ada1a3e..59a328a 100644 >> --- a/drivers/mmc/host/sdhci.c >> +++ b/drivers/mmc/host/sdhci.c >> @@ -1239,6 +1239,12 @@ static void sdhci_set_power(struct sdhci_host >> *host, unsigned char mode, >> spin_unlock_irq(&host->lock); >> mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd); >> spin_lock_irq(&host->lock); >> + >> + if (mode != MMC_POWER_OFF) >> + sdhci_writeb(host, SDHCI_POWER_ON, SDHCI_POWER_CONTROL); >> + else >> + sdhci_writeb(host, 0, SDHCI_POWER_CONTROL); >> + >> return; >> } >> >> >> Thanks again for your help in getting to the bottom of this. > > Sorry for the delay, but > > Tested-by: Bjorn Andersson > > Regards, > Bjorn Thanks. I really appreciate your help. -Tim