linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Drake <drake@endlessm.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
	Ken Xue <Ken.Xue@amd.com>, Thomas Gleixner <tglx@linutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl/amd: use byte access to clear irq/wake status bits
Date: Tue, 24 Jul 2018 07:29:04 -0500	[thread overview]
Message-ID: <CAD8Lp44Ty9x7UF0=QOpqG-Yeo4rg0ep0VfTuW5FaDuXE1VQO+w@mail.gmail.com> (raw)
In-Reply-To: <CAGS+omDPkC=Tv7SJ91cLxrFnab_VPC3VZRAugkvAUokkkoYSTg@mail.gmail.com>

On Fri, Jul 20, 2018 at 6:38 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:
> Sounds reasonable.  How about:
>
> -                       /* Clear interrupt.
> -                        * We must read the pin register again, in case the
> -                        * value was changed while executing
> -                        * generic_handle_irq() above.
> +                       /*
> +                        * Write-1-to-clear irq/wake status bits in MSByte.
> +                        * All other bits in this byte are read-only.
> +                        * This avoids modifying the lower 24-bits
> because they may have
> +                        *  changed while executing generic_handle_irq() above.
>                          */

That looks good. Thanks

Daniel

  reply	other threads:[~2018-07-24 12:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17  0:57 [PATCH 1/2] pinctrl/amd: only handle irq if it is pending and unmasked Daniel Kurtz
2018-07-17  0:57 ` [PATCH 2/2] pinctrl/amd: use byte access to clear irq/wake status bits Daniel Kurtz
2018-07-17 12:30   ` Daniel Drake
2018-07-20 23:38     ` Daniel Kurtz
2018-07-24 12:29       ` Daniel Drake [this message]
2018-07-19 14:54 ` [PATCH 1/2] pinctrl/amd: only handle irq if it is pending and unmasked Thomas Gleixner
2018-07-29 20:44 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD8Lp44Ty9x7UF0=QOpqG-Yeo4rg0ep0VfTuW5FaDuXE1VQO+w@mail.gmail.com' \
    --to=drake@endlessm.com \
    --cc=Ken.Xue@amd.com \
    --cc=Nehal-bakulchandra.Shah@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=djkurtz@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).