linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Drake <drake@endlessm.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	ben-linux@fluff.org, Russell King <linux@arm.linux.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Mike Turquette <mturquette@linaro.org>,
	thomas.abraham@linaro.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	InKi Dae <inki.dae@samsung.com>,
	geunsik.lim@samsung.com, jh80.chung@samsung.com,
	jaewon02.kim@samsung.com, ideal.song@samsung.com,
	yj44.cho@samsung.com
Subject: Re: [PATCH 5/5] ARM: dts: Add dts files for Exynos4415 SoC
Date: Fri, 24 Oct 2014 07:44:21 -0600	[thread overview]
Message-ID: <CAD8Lp45thqGRm-SjFnnht1EGuFYWabG_D9vWUQt+NnCcgVG7bg@mail.gmail.com> (raw)
In-Reply-To: <544A5578.7030009@samsung.com>

On Fri, Oct 24, 2014 at 7:34 AM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Well, I also thought about such approach, but there are some fundamental
> differences:
> interrupt and clock controllers are completely different. Using a common
> exynos4.dtsi
> and overriding them in every node will result in a code, which is a bit hard
> to follow.
> IMHO with such differences justifies using separate base dtsi file.

For the things that aren't in common, they are already split out into
soc-specific files for the existing Exynos4 variants. Taking your
example of the CMU, it already differs in different exynos4 versions
therefore is not listed in exynos4.dtsi at all.

So this argument only seems valid if the differences are really huge,
or if you are also saying the existing exynos4 dts files are bad?
Personally I have come to like the current layout, although would
definitely appreciate the reference-based syntax mentioned by Tomasz,
and this seems like a good opportunity to at least fix up exynos4.dtsi
for that.

Daniel

  reply	other threads:[~2014-10-24 13:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20  3:29 [PATCH 0/5] Support new Exynos4415 SoC based on Cortex-A9 quad cores Chanwoo Choi
2014-10-20  3:32 ` [PATCH 1/5] ARM: EXYNOS: Add EXYNOS4415 SoC ID Chanwoo Choi
2014-10-24 11:43   ` Tomasz Figa
2014-10-24 11:46     ` Chanwoo Choi
2014-10-20  3:32 ` [PATCH 2/5] clk: samsung: exynos4415: Add clocks using common clock framework Chanwoo Choi
2014-10-24 10:54   ` Sylwester Nawrocki
2014-10-24 10:59     ` Chanwoo Choi
2014-10-24 13:18   ` Daniel Drake
2014-10-24 13:28     ` Tomasz Figa
2014-10-24 13:36     ` Chanwoo Choi
2014-10-24 13:56     ` Sylwester Nawrocki
2014-10-20  3:32 ` [PATCH 3/5] clk: samsung: Document binding for Exynos4415 clock controller Chanwoo Choi
2014-10-24 10:32   ` Sylwester Nawrocki
2014-10-24 10:34     ` Chanwoo Choi
2014-10-20  3:32 ` [PATCH 4/5] pinctrl: exynos: Add support for Exynos4415 Chanwoo Choi
2014-10-20  3:32 ` [PATCH 5/5] ARM: dts: Add dts files for Exynos4415 SoC Chanwoo Choi
2014-10-24 13:23   ` Daniel Drake
2014-10-24 13:30     ` Tomasz Figa
2014-10-24 13:34     ` Marek Szyprowski
2014-10-24 13:44       ` Daniel Drake [this message]
2014-10-24 13:53     ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD8Lp45thqGRm-SjFnnht1EGuFYWabG_D9vWUQt+NnCcgVG7bg@mail.gmail.com \
    --to=drake@endlessm.com \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=cw00.choi@samsung.com \
    --cc=geunsik.lim@samsung.com \
    --cc=ideal.song@samsung.com \
    --cc=inki.dae@samsung.com \
    --cc=jaewon02.kim@samsung.com \
    --cc=jh80.chung@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@linaro.org \
    --cc=olof@lixom.net \
    --cc=sw0312.kim@samsung.com \
    --cc=thomas.abraham@linaro.org \
    --cc=tomasz.figa@gmail.com \
    --cc=yj44.cho@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).