From: Maxim Uvarov <maxim.uvarov@linaro.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Atish Patra" <atish.patra@wdc.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Arvind Sankar" <nivedita@alum.mit.edu>,
linux-efi <linux-efi@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jens Wiklander" <jens.wiklander@linaro.org>,
"François Ozog" <francois.ozog@linaro.org>
Subject: Re: [PATCH 1/1] efi/libstub: DRAM base calculation
Date: Wed, 9 Sep 2020 13:43:48 +0300 [thread overview]
Message-ID: <CAD8XO3YGUUz6B4NDBC-f4Rfhhyya6GPwjW2oxP=GANRoNyydsQ@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXGYpMMrQPgL-SNde75EbDX8RZBDrboEuMcjJ7-cyEJUXg@mail.gmail.com>
On Wed, 9 Sep 2020 at 11:17, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> (+ Atish, Palmer)
>
> On Fri, 4 Sep 2020 at 18:50, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > In the memory map the regions with the lowest addresses may be of type
> > EFI_RESERVED_TYPE. The reserved areas may be discontinuous relative to the
> > rest of the memory. So for calculating the maximum loading address for the
> > device tree and the initial ramdisk image these reserved areas should not
> > be taken into account.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> > drivers/firmware/efi/libstub/efi-stub.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/efi/libstub/efi-stub.c b/drivers/firmware/efi/libstub/efi-stub.c
> > index c2484bf75c5d..13058ac75765 100644
> > --- a/drivers/firmware/efi/libstub/efi-stub.c
> > +++ b/drivers/firmware/efi/libstub/efi-stub.c
> > @@ -106,7 +106,8 @@ static unsigned long get_dram_base(void)
> > map.map_end = map.map + map_size;
> >
> > for_each_efi_memory_desc_in_map(&map, md) {
> > - if (md->attribute & EFI_MEMORY_WB) {
> > + if (md->attribute & EFI_MEMORY_WB &&
> > + md->type != EFI_RESERVED_TYPE) {
> > if (membase > md->phys_addr)
> > membase = md->phys_addr;
> > }
> > --
> > 2.28.0
> >
>
> This is not the right fix - on RPi2, for instance, which has some
> reserved memory at the base of DRAM, this change will result in the
> first 16 MB of memory to be wasted.
>
In the EFI memmap provided to the kernel efi stub it will be 2
regions. First is EFI_RESERVED and second is EFI_CONVENTIONAL_MEMORY.
Even if they follow each other.
And for_each_efi_memory_desc_in_map will just return the second one.
Do not see where the problem is here.
> What I would prefer to do is get rid of get_dram_base() entirely -
> arm64 does not use its return value in the first place, and for ARM,
> the only reason we need it is so that we can place the uncompressed
> kernel image as low in memory as possible, and there are probably
> better ways to do that. RISC-V just started using it too, but only
> passes it from handle_kernel_image() to efi_relocate_kernel(), and
> afaict, passing 0x0 there instead would not cause any problems.
For prior 5.8 kernels there was limitation for maximum address to
unpack the kernel. As I understand that was copy-pasted from x86 code,
and now is missing in 5.9. That is why the suggestion was to point
dram_base to the region where it's possible to allocate. I.e. I assume
that
patch was created not to the latest kernel. Removing the upper
allocation limit should work here.
Maxim.
next prev parent reply other threads:[~2020-09-09 10:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 15:50 [PATCH 1/1] efi/libstub: DRAM base calculation Heinrich Schuchardt
2020-09-07 7:00 ` Maxim Uvarov
2020-09-07 8:30 ` Heinrich Schuchardt
2020-09-07 10:21 ` Maxim Uvarov
2020-09-07 15:42 ` Maxim Uvarov
2020-09-09 8:17 ` Ard Biesheuvel
2020-09-09 10:43 ` Maxim Uvarov [this message]
2020-09-09 10:46 ` Ard Biesheuvel
2020-09-09 11:04 ` Maxim Uvarov
2020-09-09 20:36 ` Atish Patra
2020-09-10 10:03 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD8XO3YGUUz6B4NDBC-f4Rfhhyya6GPwjW2oxP=GANRoNyydsQ@mail.gmail.com' \
--to=maxim.uvarov@linaro.org \
--cc=ardb@kernel.org \
--cc=atish.patra@wdc.com \
--cc=francois.ozog@linaro.org \
--cc=jens.wiklander@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=palmer@dabbelt.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).