From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752188AbeC0V6B (ORCPT ); Tue, 27 Mar 2018 17:58:01 -0400 Received: from mail-ua0-f177.google.com ([209.85.217.177]:44363 "EHLO mail-ua0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbeC0V56 (ORCPT ); Tue, 27 Mar 2018 17:57:58 -0400 X-Google-Smtp-Source: AIpwx49CTsU9XD/C+/aEw9zO9DKEqMAHA+CprTIpVyPFnOpU77Oe7yOoPvnFf4iZnRlCOG2G65nKwG2TallVRkzBK7I= MIME-Version: 1.0 In-Reply-To: <1521785487-29866-6-git-send-email-mgautam@codeaurora.org> References: <1521785487-29866-1-git-send-email-mgautam@codeaurora.org> <1521785487-29866-6-git-send-email-mgautam@codeaurora.org> From: Doug Anderson Date: Tue, 27 Mar 2018 14:57:55 -0700 X-Google-Sender-Auth: 41lKj8kyFwqMyvWtYo0A-hKdUmk Message-ID: Subject: Re: [PATCH v3 5/6] dt-bindings: phy-qcom-usb2: Update bindings for sdm845 To: Manu Gautam , Rob Herring Cc: Kishon Vijay Abraham I , LKML , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Mark Rutland , Vivek Gautam , Stephen Boyd Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Mar 22, 2018 at 11:11 PM, Manu Gautam wrote: > Update compatible strings for USB2 PHYs on sdm845. > There are two QUSB2 PHYs present on sdm845. Few PHY registers > programming is different for these PHYs related to electrical > parameters, otherwise both are same. > > Signed-off-by: Manu Gautam > --- > Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > index 42c9742..b99a57f 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > Required properties: > - compatible: compatible list, contains > "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. > + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY, > + "qcom,sdm845-qusb2-phy-1" for primary PHY on sdm845, > + "qcom,sdm845-qusb2-phy-2" for secondary PHY on sdm845. Similar question to the one I posed on for the QMP PHY. What is "qcom,qusb2-v2-phy"? Is it some ideal abstract version of the PHY? Do we expect that anyone would actually use that compatible string? In this case in it looks as if you're using the same settings as "qcom,sdm845-qusb2-phy-2", so presumably "qcom,qusb2-v2-phy" should just be deleted. -Doug